Closed
Bug 1017661
Opened 10 years ago
Closed 10 years ago
remove MOZ_NSS_PATCH functionality
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
2.07 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
This stuff seems really dodgy. If we need to patch NSS, presumably we should be committing changes to hg so we have a record of what's been done, even if we have to roll things back later.
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8430876 [details] [diff] [review] remove MOZ_NSS_PATCH functionality See comment 1 for rationale.
Attachment #8430876 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 4•10 years ago
|
||
So we have this functionality, but it's currently unused and we've (likely) never used it for going on five years?
Comment 5•10 years ago
|
||
ISTR having seen it used.
Comment 6•10 years ago
|
||
Comment on attachment 8430876 [details] [diff] [review] remove MOZ_NSS_PATCH functionality Review of attachment 8430876 [details] [diff] [review]: ----------------------------------------------------------------- ::: security/build/Makefile.in @@ +256,1 @@ > NSS_SRCDIR = $(topsrcdir) You could remove this variable and replace if with topsrcdir everywhere it's used.
Attachment #8430876 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Since Vlad requested the functionality to be added in bug 511743, perhaps he has suggestions on whether this feature's time has come and gone. Vlad?
Flags: needinfo?(vladimir)
Sure, nuke away
Flags: needinfo?(vladimir)
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ef6fc5965a4c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nfroyd
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•