1018379 - [Geolocation]Random location jumping when using Marketplace App HERE Maps while device is stationary

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[:garvan]

This is the mozilla-central version of this bug: Bug #1007953, which was Tarako-only. This bug is to request a patch for central. 

Although having been seen originally on Tarako, this would affect other platforms.

Summary ----------------
Description: User downloads, installs, and launches Marketplace App HERE Maps. User elects to allow HERE Maps to know one's location. Zoom in several times and user witnesses the green dot jumping several miles from East to West and vice versa ever so often. 
------------------------

See original for more information.

Comment 1

[Doug Turner (:dougt)]

Attachment: attachment.cgi?id=8430238

Carrying forward the r+ from jdm from bug 1007953.  This patch applies to m-c.

Comment 2

[Doug Turner (:dougt)]

https://tbpl.mozilla.org/?tree=Try&rev=31213666be13

Comment 3

[:garvan]

>   notify: function (timeoutTimer) {
>+    // If Wifi scanning is disabled, then we can not depend on that for the
>+    // heartbeat that drives location updates.  Instead, just use a timer which
>+    // will drive the update.
>+    if (gWifiScanningEnabled == false) {
>+        this.sendLocationRequest(null);
>+    }
>+  },
>+

The case where wifi is running, then gets shut off is not handled that I can see.
Would change this to do this first in the function.

try {
 gWifiScanningEnabled = Services.prefs.getBoolPref("geo.wifi.scan");
} catch (e) {}

Alternatively, we could listen for this setting change.

Comment 4

[Doug Turner (:dougt)]

Garvan -- you're going to love this.

Summary:

This isn't the only patch needed for FirefoxOS.  I need to also fix the wifi scanning code so that onerror is returned if wifi is disabled.

Background:

There are two permission like things in gecko/b2g.  There is preference (Services.prefs.get*Pref()).  This is used basically everywhere.  Go look in about:config for all of the visible preferences in Firefox desktop.  In FirefoxOS, there is something call Settings.  These are kind of like preferences, but they are completely different.  The history has something to do with the 'preference' api is kind of shitty for things -- it is synchronous for one.

On FirefoxOS, if you open the Settings app, those things are Settings -- not gecko preferences

Result:

So, the things we are dealing with in this patch are gecko style preferences and not settings.  When in FirefoxOS the user turns off WiFi Scanning, this preference is not toggled.  This preference we are using here is specific only to the provider.  It answers "should we even try to use wifi ever".  It is typically always true, and it is toggled for mochitests

Comment 5

[:garvan]

Hopefully just this (although I suspect nothing comes easily):
boolean gWifiScanningEnabled_B2GSetting; // init to true on startup

onerror() { gWifiScanningEnabled_B2GSetting = false; }
// assuming the scanning keeps running after onerror()
onchange() { gWifiScanningEnabled_B2GSetting = true; }

and notify() gets
if (!gWifiScanningEnabled_StandardPref || !gWifiScanningEnabled_B2GSetting) { sendLocationRequest() }

Comment 6

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba5f01898068

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba5f01898068

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4674e62192c4

Needs a branch patch for b2g30 (v1.4) uplift.

Comment 9

[Doug Turner (:dougt)]

There is a set of 4 changesets that should all be applied together.  They were all nominated together.

Comment 10

[Preeti Raghunath(:Preeti)]

Dolphin fixes will need to land on 1.4 Dolphin branch.

Comment 11

[Doug Turner (:dougt)]

Preeti -- How are we going to make sure that this lands on dophin?

Comment 12

[Preeti Raghunath(:Preeti)]

Doug,

I've marked the bug with the white board [dolphin land] now. Once we've created the flags 1.4D? and 1.4D+ we will tag all these bugs with the flags 1.4D+. I hope this helps.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Doug, this is the first patch in that stack and it doesn't apply to b2g30. You're going to need to rebase for v1.4 uplift.

Comment 14

[Chris Peterson [:cpeterson]]

Doug: Ryan says you need to rebase this patch.

Comment 15

[Doug Turner (:dougt)]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/d0a9600aa3b0