1018484 - django has a test failure on 32-bit systems

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

webapp-django/crashstats/crashstats/tests/test_views.py passes a date from 2085 to mktime, which will not work on 32-bit systems (32-bit int used for epoch overflows in 2032)

The reason I hit this is because Vagrant spins up a 32-bit VM (in case people are using a 32-bit system and can't run 64-bit VMs)

So is the bug here:

1) 32-bit systems are unsupported
2) we need to mock a date < 2032

I think at this point in time it should be #2 since 32-bit is not dead (we switched to 32-bit Vagrant VM specifically in response to complaints)

Comment 1

[Robert Helmer [:rhelmer]]

PR: https://github.com/mozilla/socorro/pull/2071

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/59df9d1c3f1b79010b9d6fff46e1c0febdd9f706
fix bug 1018484 - mktime cannot use a date this far in the future on 32-bit systems such as our vagrant VM

https://github.com/mozilla/socorro/commit/d78ed26cf9fc8da86eba7606e64fda400f74e955
Merge pull request #2071 from rhelmer/bug1018484-32-bit-mktime-fail

fix bug 1018484 - mktime cannot use a date this far in the future on 32-...