Closed
Bug 1019292
Opened 10 years ago
Closed 10 years ago
Balrog release submissions should adjust productName as needed
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: nthomas)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.89 KB,
patch
|
bhearsum
:
review+
nthomas
:
checked-in+
|
Details | Diff | Splinter Review |
We're creating urls like https://www.mozilla.org/en-US/Firefox/30.0/releasenotes/ instead of https://www.mozilla.org/en-US/firefox/30.0/releasenotes/ AFAIK we don't have any B2G use case here, so it's 50/50 whether you .lower() in the function or when you call it.
Attachment #8432878 -
Flags: review?(bhearsum)
|
Assignee | |
Updated•10 years ago
|
Blocks: balrog-beta
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8432878 [details] [diff] [review] [tools] .lower() .lower() .lower() do the limbo! Review of attachment 8432878 [details] [diff] [review]: ----------------------------------------------------------------- I've been trying to err on the side of pushing .lower() and .capitalize() as far up the call stack as possible (which is admittedly difficult). Is there a reason not to put this in submitter/cli.py instead?
|
|
Assignee | |
Comment 2•10 years ago
|
||
That's fine. Turns out there are other things to fix too.
Summary: detailsUrl needs lowercase product in balrog submissions → Balrog release submissions submissions should adjust productName as needed
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8432878 -
Attachment is obsolete: true
Attachment #8432878 -
Flags: review?(bhearsum)
Attachment #8433658 -
Flags: review?(bhearsum)
|
|
||
Updated•10 years ago
|
Attachment #8433658 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Updated•10 years ago
|
Summary: Balrog release submissions submissions should adjust productName as needed → Balrog release submissions should adjust productName as needed
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8433658 [details] [diff] [review] [tools] Fixes paths for test updates too https://hg.mozilla.org/build/tools/rev/524bdee72020
Attachment #8433658 -
Flags: checked-in+
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•