1019372 - [bluetooth2] Avoid accessing static variables on different thread

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

Bug 1015826 avoids accessing static variables on different thread. The fix should be also applied on bluetooth2.

Comment 1

[Ben Tian (inactive)]

Attachment: Patch 1/6 (v1): [bluetooth2] Remove unneccessary variable sIsBtEnabled to avoid racing issue

Comment 2

[Ben Tian (inactive)]

Attachment: Patch 2/6 (v1): [bluetooth2] Dispatch part of AdapterPropertiesCallback to main thread

Comment 3

[Ben Tian (inactive)]

Attachment: Patch 3/6 (v1): [bluetooth2] Use Atomic on certain primitive variables to ensure thread-safe

Comment 4

[Ben Tian (inactive)]

Attachment: Patch 4/6 (v1): [bluetooth2] Dispatch part of RemoteDevicePropertiesCallback to main thread

Comment 5

[Ben Tian (inactive)]

Attachment: Patch 5/6 (v1): [bluetooth2] Dispatch part of BondStateChangedCallback to main thread

Comment 6

[Ben Tian (inactive)]

Attachment: Patch 6/6 (v1): [bluetooth2] Dispatch part of DiscoveryChangedCallback to main thread

Comment 7

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8433026 [details] [diff] [review]
Patch 6/6 (v1): [bluetooth2] Dispatch part of DiscoveryChangedCallback to main thread

Review of attachment 8433026 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 8

[Ben Tian (inactive)]

Set 'checkin-needed' for patch 1 ~ 6.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Do you have a link to a recent Try push handy by chance? :)

Comment 10

[Ben Tian (inactive)]

The patches don't affect tpbl result since the affected files are not built yet. They are WIP files for new bluetooth API.

Comment 11

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/d45fe00e7dcd
https://hg.mozilla.org/integration/b2g-inbound/rev/76fc983a3813
https://hg.mozilla.org/integration/b2g-inbound/rev/73b2cef37ebc
https://hg.mozilla.org/integration/b2g-inbound/rev/1949c7590771
https://hg.mozilla.org/integration/b2g-inbound/rev/97da7dcaf95b
https://hg.mozilla.org/integration/b2g-inbound/rev/39c24d61a1b8

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d45fe00e7dcd
https://hg.mozilla.org/mozilla-central/rev/76fc983a3813
https://hg.mozilla.org/mozilla-central/rev/73b2cef37ebc
https://hg.mozilla.org/mozilla-central/rev/1949c7590771
https://hg.mozilla.org/mozilla-central/rev/97da7dcaf95b
https://hg.mozilla.org/mozilla-central/rev/39c24d61a1b8