1019437 - Add 'waitForNotificationUnload' method in locationBar class

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniel Gherasim]

As discussed in bug 994040, a method to close notifications & wait for them to be completely unloaded would be nice to have in our toolbars.js/locationBar class.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When you want to have this a mentored bug, more information has to be specified. Best would be an example, and a pointer to the currently existing code. Right now it will be hard to understand for someone new in that project.

Comment 2

[Daniel Gherasim]

Bug 994040 is fixed now so I'll give some more information here as requested.

What we need here is to add a new method in the locationBar class in this file:
http://hg.mozilla.org/qa/mozmill-tests/file/930bde25e81d/firefox/lib/toolbars.js#l319

that will replace the code in several tests, like this one:

http://hg.mozilla.org/qa/mozmill-tests/file/930bde25e81d/firefox/tests/functional/testPreferences/testPasswordSavedAndDeleted.js#l61

The method will look like:

waitForNotificationUnload() {
  // call waitForNotificationPanel method with the specific callback code to close the notification;
}

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to daniel.gherasim from comment #2)
> waitForNotificationUnload() {
>   // call waitForNotificationPanel method with the specific callback code to
> close the notification;
> }

Why another wrapper here? I don't think this is worth, given that you still have to add the other aSpec values.

Comment 4

[mustafa]

Hi, I am a Computing student that would like to be assigned this bug.

Comment 5

[Andreea Matei [:AndreeaMatei]]

Hi Mustafa, thanks for your interest. Please see the comments for what the bug has to do and you can also get familiar with mozmill and mozmill tests with this documentation:
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Mozmill_tests

Let me know if you have questions, here or on the #automation channel. Thanks!

Comment 6

[mustafa]

Hi Andreea, does this mean I have been assigned to this bug can you please confirm that. Thank you.

Comment 7

[Andreea Matei [:AndreeaMatei]]

Yes, I assigned you :)

Comment 8

[mustafa]

Thank you Andreea :), quick question is it possible that you draw up a list for me of the things that are needed to fix this bug?

Regards
Mustafa

Comment 9

[Andreea Matei [:AndreeaMatei]]

Actually, I'm afraid we don't need this change anymore since in bug 994040 we have implemented the unload of the notification in the same method. Can I suggest to you bug 882137? It's a refactoring one, to update the jsdoc for each function. If you have questions, lets move to that bug.

Comment 10

[mustafa]

thats a shame,  could you assign me to that one please and also tell me what is needed for it.