Closed
Bug 1019476
Opened 10 years ago
Closed 10 years ago
Can't use an undefined value as an ARRAY reference (Bugzilla/User.pm:773)
Categories
(Bugzilla :: Bugzilla-General, defect)
Bugzilla
Bugzilla-General
Tracking
()
RESOLVED
INVALID
People
(Reporter: glob, Assigned: glob)
References
Details
Attachments
(1 file)
321 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
when viewing bugs with an empty cc list: Can't use an undefined value as an ARRAY reference (Bugzilla/User.pm:773)
Attachment #8433202 -
Flags: review?(dkl)
Comment 2•10 years ago
|
||
Note that only BMO's Bugzilla::Bug->cc contains the line: $self->{'cc'} = undef if !scalar(@{$self->{'cc'}}); But upstream bugzilla does not, and $self->{'cc'} will always be defined. Git blame does not enlighten as to why this change is in BMO but not upstream.
Comment 3•10 years ago
|
||
Comment on attachment 8433202 [details] [diff] [review] 1019476_1.patch Review of attachment 8433202 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl
Attachment #8433202 -
Flags: review?(dkl) → review+
Updated•10 years ago
|
Flags: approval?
(In reply to Dylan William Hardison [:dylan] from comment #2) > Note that only BMO's Bugzilla::Bug->cc contains the line: > $self->{'cc'} = undef if !scalar(@{$self->{'cc'}}); > But upstream bugzilla does not, and $self->{'cc'} will always be defined. > Git blame does not enlighten as to why this change is in BMO but not > upstream. that line was removed by bug 819330 (bugzilla 4.4), which is why it's still present on bmo (bugzilla 4.2).
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: approval?
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•