1019534 - [Collection App] Migrate data to vertical homescreen format

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

See bug 1018852 comment 4

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

10x

Comment 2

[Amir Nissim (:amirn)]

I'm sorry Crisitian, but I now realized that `apps` are called `pinned`.

I will compile a home1->home2 mapping of field names later this week.
changing the scope of this bug to match bug 1018852 comment 4

thanks.

Comment 3

[Cristian Rodriguez (:crdlc)]

ok, apps to pinned, right? any change more?

Comment 4

[Amir Nissim (:amirn)]

change (home1 -> home2):
bg -> background
experienceId -> categoryId
apps -> pinned (TODO migrate the objects to vertical homescreen items)
extraIconsData -> webicons


no-change:
name -> name
icon -> icon
defaultIcon -> defaultIcon
query -> query

Comment 5

[Cristian Rodriguez (:crdlc)]

experienceId or provider_id?

Comment 6

[Amir Nissim (:amirn)]

both:

(only exists for user created collections)  experienceId -> categoryId 
(only exists for pre-installed collections) provider_id -> categoryId

sorry.

Comment 7

[Cristian Rodriguez (:crdlc)]

The homescreen had in its database

(In reply to Amir Nissim (Everything.me) from comment #4)
> change (home1 -> home2):
> bg -> background NO
> experienceId -> categoryId YES (see https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid_components.js#L106)
> apps -> pinned (TODO migrate the objects to vertical homescreen items) YES
> extraIconsData -> webicons NO
> 
> 
> no-change:
> name -> name YES
> icon -> icon YES
> defaultIcon -> defaultIcon NO
> query -> query NO

Comment 8

[Cristian Rodriguez (:crdlc)]

and the path of icons was saved like

app://homescreen.gaiamobile.org/collections/social/icon.png

so should we change it to

app://collection.gaiamobile.org/collections/social/icon.png

right?

Comment 9

[Cristian Rodriguez (:crdlc)]

Added categoryId, pinned and icon with the correct path to the PR. The homescreen hadn't info about bg, extraIconsData, defaultIcon nor query. Is it in some indexedDB of evme?

Comment 10

[Cristian Rodriguez (:crdlc)]

Done Amir, please you can review right now

Comment 11

[Amir Nissim (:amirn)]

Comment on attachment 8433260 [details]
Github pull request

added comments on GH.

didn't get a chance to test on device, but don't want to block you from making progress.

Thank you very much Cristian!

Comment 12

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/c149fdc2235cbc8e800a43a30630b9559978ebe2

Comment 13

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.