Closed
Bug 1019692
Opened 10 years ago
Closed 10 years ago
Changes to user's data in login should be pushed into login cookies without a login/logout
Categories
(Webmaker Graveyard :: Login, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kate, Assigned: cade)
References
Details
(Whiteboard: [badges] [july25][webmaker-badges][launch])
Attachments
(5 files)
|
48 bytes,
text/x-github-pull-request
|
jon
:
review+
kate
:
feedback+
jon
:
feedback+
|
Details | Review |
|
55 bytes,
text/x-github-pull-request
|
kate
:
review+
|
Details | Review |
|
48 bytes,
text/x-github-pull-request
|
kate
:
review+
|
Details | Review |
|
568 bytes,
text/plain
|
kate
:
review+
|
Details |
|
53 bytes,
text/x-github-pull-request
|
kate
:
review+
|
Details | Review |
Perhaps a verify could ping the server every 15 minutes or so to check in changes have been made (admin status, etc)
|
Reporter | |
Updated•10 years ago
|
Assignee: jon → kate
|
|
Reporter | |
Updated•10 years ago
|
Whiteboard: [June13][webmaker-badges][launch] → [june13][webmaker-badges][launch]
|
||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [june13][webmaker-badges][launch] → [badges] [june13][webmaker-badges][launch]
|
|
Reporter | |
Updated•10 years ago
|
Whiteboard: [badges] [june13][webmaker-badges][launch] → [badges] [june27][webmaker-badges][launch]
|
Assignee | |
Comment 2•10 years ago
|
||
Is this kinda what we were looking for? Basically, it tacks a timestamp onto ever session that's generated, and the verify route checks how old it is. If it's older than a configured time (15 minute default) it is refreshed. We could potentially add in a param to force a refresh, which might be useful in some situations.
Attachment #8441598 -
Flags: feedback?(kate)
Attachment #8441598 -
Flags: feedback?(jon)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8441598 [details] [review] https://github.com/mozilla/webmaker-auth/pull/11 the approach looks solid, I'm just wondering about the use of login credentials.
Attachment #8441598 -
Flags: feedback?(jon) → feedback+
|
|
Reporter | |
Comment 4•10 years ago
|
||
Yeah looks good to me
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8441598 -
Flags: feedback?(kate) → feedback+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8441598 [details] [review] https://github.com/mozilla/webmaker-auth/pull/11 Lets move this into code review.
Attachment #8441598 -
Flags: review?(jon)
|
|
||
Updated•10 years ago
|
Attachment #8441598 -
Flags: review?(jon) → review-
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8441598 -
Flags: review- → review?(jon)
|
|
||
Updated•10 years ago
|
Whiteboard: [badges] [june27][webmaker-badges][launch] → [badges] [july11][webmaker-badges][launch]
|
|
||
Updated•10 years ago
|
Attachment #8441598 -
Flags: review?(jon) → review+
|
|
||
Comment 6•10 years ago
|
||
oh wait, one nit: can you add the authLoginUrl to the example server?
|
|
||
Updated•10 years ago
|
Flags: needinfo?(cade)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Attachment #8451907 -
Flags: review?(jon)
Flags: needinfo?(cade)
|
|
Assignee | |
Comment 8•10 years ago
|
||
we'll need to update apps to use v0.1.2 of webmaker-auth
|
|
Assignee | |
Comment 9•10 years ago
|
||
The Boolean logic around not refreshing if there's no authLoginURL is broken.
it's currently `if(a && !b || c) {}` and should be `if (a && (!b || c)) {}`
the former will execute even if 'a' is falsy, the latter behaves as expected.
Attachment #8451921 -
Flags: review?(jon)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8451921 -
Flags: review?(jon) → review?(kate)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8451907 -
Flags: review?(jon) → review?(kate)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8451907 -
Flags: review?(kate) → review+
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8451921 -
Flags: review?(kate) → review+
|
|
Assignee | |
Comment 10•10 years ago
|
||
MakeAPI: https://github.com/mozilla/MakeAPI/pull/230 WMLogin: https://github.com/mozilla/login.webmaker.org/pull/284 WebmakerOrg: https://github.com/mozilla/webmaker.org/pull/855 Webmaker-Events-Service: https://github.com/mozilla/webmaker-events-service/pull/56 Webmaker-Events-2: https://github.com/mozilla/webmaker-events-2/pull/127 Thimble: https://github.com/mozilla/thimble.webmaker.org/pull/435 Popcorn Maker: https://github.com/mozilla/popcorn.webmaker.org/pull/556 Goggles: https://github.com/mozilla/goggles.webmaker.org/pull/139 Appmaker & profile will follow.
Attachment #8453140 -
Flags: review?(kate)
|
|
Reporter | |
Comment 11•10 years ago
|
||
Comment on attachment 8453140 [details]
Webmaker Auth updates (links to Github PR's)
Everything looks good, make sure you set all those vars on prod and staging config and double check 'em
Attachment #8453140 -
Flags: review?(kate) → review+
|
|
Assignee | |
Comment 12•10 years ago
|
||
update for profile. The Appmaker change is at: https://github.com/mozilla-appmaker/appmaker/issues/1651
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8453230 -
Flags: review?(kate)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8453230 -
Flags: review?(kate) → review+
|
|
||
Updated•10 years ago
|
Whiteboard: [badges] [july11][webmaker-badges][launch] → [badges] [july25][webmaker-badges][launch]
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•