1019805 - Copy dashboard fails if device ID is specified and no results exist for that device

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The first build of a new device fails in Eideticker CI because the copy-dashboard script tries to download dashboard history for a device with no prior results. We should probably just silently ignore if there are no matching results.

+ ./bin/copy-dashboard.py --device-id flame --skip-metadata http://eideticker.mozilla.org/b2g/ /var/jenkins/workspace/b2g.flame.mozilla-central.tests/dashboard/
Traceback (most recent call last):
  File "./bin/copy-dashboard.py", line 110, in <module>
    testnames = tests.json()['tests'].keys()
  File "/usr/lib/python2.7/dist-packages/requests/models.py", line 741, in json
    return json.loads(self.text, **kwargs)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

Comment 1

[William Lachance (:wlach)]

Attachment: Fix

I think this should do the trick.

Comment 2

[William Lachance (:wlach)]

Landed: https://github.com/mozilla/eideticker/commit/abac6657f4d0b64b64bee3560263352293fb055e