1019883 - "expected" field of structured log messages should should not be populated for skipped tests

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

mozlog.structured populates the 'expected' field of log messages in cases status != expected, including when the test status is 'SKIP' and the expected is 'PASS'. 

This convention appears to be used to determining when a test is considered a failure by the test run, which arguably not the case for skipped tests. Either we can stop depending on this convention, or not populate the field for 'SKIP' tests. I will post a patch doing the latter.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Don't populate expected field in log messages for skipped tests.;

Comment 2

[James Graham [:jgraham]]

Comment on attachment 8433586 [details] [diff] [review]
Don't populate expected field in log messages for skipped tests.;

Review of attachment 8433586 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think this makes sense.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c19d5dcd5759

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c19d5dcd5759