Closed Bug 1019932 Opened 10 years ago Closed 8 years ago

messenger.properties should use string based identifiers rather than numbers

Categories

(MailNews Core :: Networking, defect)

Product:
MailNews Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 47.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file, 2 obsolete files)

patch v2.1
7.86 KB, patch
aceman
: review+
Details | Diff | Splinter Review 
There are some remaining numeric string identifiers in messenger.properties. This makes it harder for localisers to work with, and means that if we need to tweak strings then it isn't easy to change the string identifier to notify the localisers.

We should work on replacing the numbers with strings.
This bug serves the same purpose as bug #858238 and bug #551919.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #8433622 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 8433622 [details] [diff] [review]
patch

We never fetch the "Unknown Error" message, so you should remove it from the properties file and use nullptr as the sentinel value instead (which allows you to do a pointer compare).

        Attachment #8433622 -
        Flags: review?(neil) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2 (obsolete)
        — 
          — Splinter Review
      

    


  
OK.

        Attachment #8433622 -
        Attachment is obsolete: true

        Attachment #8436072 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 8436072 [details] [diff] [review]
patch v2

(I wonder why I didn't bikeshed about the naming of errorString or whether FormatStringWIthHotNameByName should be a private static class method.)

        Attachment #8436072 -
        Flags: review?(neil) → review+

    
    

    
  
I wonder why this never landed. Let's check if it still applies ;)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2.1
        — 
          — Splinter Review
      

    


  
Updated to current trunk.

        Attachment #8436072 -
        Attachment is obsolete: true

        Attachment #8720986 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/comm-central/rev/2c5cd6504ce2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: