102013 - nsIFilePicker (widget) returns a nsIURI (necko)

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Alec Flett]

We have a wierd dependency between widget and necko: if you are a consumer of
nsIFilePicker, you have to pull in necko because nsIFilePicker returns an nsIURI.

I have two ideas, looking for input:
- change nsIFilePicker to return an nsIFile or nsILocalFile
- move nsIFilePicker into xpfe somewhere.

I prefer the first option (use nsIFile)

Comment 1

[Judson Valeski]

yea, option #1 seems to make sense, though, even after doing that, I think we're
still bound to necko (bugzilla 100212 should be a blocker for this bug if we go
w/ option #1?).

Comment 2

[Alec Flett]

I'd really love to fix this, but it's just not high on the list!

Comment 3

[Alec Flett]

pushing out non-critical bugs past moz 1.0

Comment 4

[Cathleen]

topembed-
- by triage team (cofmann, cathleen, marcia)

Comment 5

[Alec Flett]

woah, 1.1 came up quick. Throwing these bugs over to 1.2.. little or no work has
been done and there is no way that these bugs can be fixed in 1.1.

Comment 6

[Alec Flett]

ugh, this is going to be a pain to fix (its all JS stuff) and with no real gain
for now. Moving out

Comment 7

[(not reading, please use [e-mail] instead)]

for the js consumers:

var ioService = Components.classes["@mozilla.org/network/io-service;1"]
ioService = ioService.getService(Components.interfaces.nsIIOService);

var fileURL = ioService.newFileURI(fp.file).QueryInterface
(Components.interfaces.

I'm using this for http://bugzilla.mozilla.org/show_bug.cgi?id=121122

how many js consumers are there?

Comment 8

[Alec Flett]

most JS consumers want the URL string, so really they should be using
ioService.getURLSpecFromFile()

However, after bug 166792 is fixed, this will be available from the
nsIFileProtocolHandler

for example, here's the first patch from attachment 97922 [details] [diff] [review]

+      var fileHandler = XPCU.QI(ioService.getProtocolHandler("file"),
"nsIFileProtocolHandler");
+
+      var url = fileHandler.getURLSpecFromFile(file);
 
-      var url = ioService.getURLSpecFromFile(file);

(slightly different in that it gets the url string, but that is often what JS
consumers want)

Comment 9

[(not reading, please use [e-mail] instead)]

ok, I'll do it your way in the file picker / compose bug.

thanks for the info.

Comment 10

[Henri Sivonen (:hsivonen)]

Resolving WORKSFORME in the sense that it's all just libxul now.