102017 - Need to apply WindowsXP Start Menu integration patch to trunk

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Bill Law]

See bug 97813.  That was fixed on the branch but the patch has to be expanded a 
bit to enable it to be checked in on the trunk.

The issue is the hard-coded "Netscape 6" string that is put in the registry to 
identify the application when it is added to the Start Menu.  The "proper" way 
to do that is to place that string into a .exe or .dll string resource and 
specify that resource via the LocalizedString value under 
HKLM\Softare\Clients\StartMenuInternet\XXXXXXXX.EXE.  This requires changes 
elsewhere to get that string resource added.  This bug is to track that work 
and the landing of the rest of the patch(es) for bug 97813 onto the trunk.

Comment 1

[Sean Su]

Attachment: installer fix for the trunk (ns tree)

Comment 2

[Sean Su]

Attachment: installer fix for the trunk (moz tree)

Comment 3

[Sean Su]

The installer patches were already r=/sr= by law and dveditz from bug 97813.

Comment 4

[Sean Su]

Comment on attachment 51140 [details] [diff] [review]
installer fix for the trunk (ns tree)

This is actually r=law/sr=dveditz, not me.

Comment 5

[Sean Su]

Comment on attachment 51141 [details] [diff] [review]
installer fix for the trunk (moz tree)

This is actually r=law/sr=dveditz, not me.

Comment 6

[Bill Law]

Attachment: Patch for non-installer changes; mostly this is identical to the bug used to add this to the mozilla0.9.4 branch

Comment 7

[Bill Law]

The changes from the (already approved) changes that were applied to the 
mozilla0.9.4 branch (via bug 97013) are:

1. A new nsINativeAppSupportWin.idl file in mozilla/xpfe/appshell/public (and 
makefile.win stuff to go with it).  This file is used to generate a separate .h 
that can be pulled into splash.rc to define the new text string (and in 
nsWindowsHooksUtils.cpp to access the value).

2. Changes splash.rc to add a new string resource for the text that will appear 
in the Start Menu (e.g., "Mozilla" for Mozilla, "Netscape 6.x" for Netscape).

3. Changes to makefile.win in mozilla/xpfe/bootstrap so that it points to 
$(XPDIST)/include/appshell when running the resource compiler so that 
nsINativeAppSupportWin.h can be found.

4. Code in nsWindowsHooksUtil.cpp (in function setWindowsXP) to build 
the "LocalizedString" registry key setting using the executable name plus 
the ",nnn" where nnn is the value from nsINativeAppSupportWin.h.

The rest of the changes (in nsWindowsHooks.cpp and nsWindowsHooksUtil.cpp) is 
the same as what was added on the branch.

Comment 8

[Bill Law]

Adding Blake to cc: list.  Review and super-review needed!

Comment 9

[Blake Ross]

Comment on attachment 54285 [details] [diff] [review]
Patch for non-installer changes; mostly this is identical to the bug used to add this to the mozilla0.9.4 branch

sr=blake pending sean's review

Comment 10

[Sean Su]

VerifyRestrictedAccess() should be changed to something like, 
IsAccessRestricted().

I don't see a similar change to ns/xpfe/bootstrap as there is to 
mozilla/xpfe/bootstrap.  Is such a patch in a bugscape bug somewhere?

Adding Srilatha to the CC: list because she will need to do similar changes wrt 
the changes in the bootstrap dir for her SMAPI trunk merge.

Comment 11

[Bill Law]

Attachment: Patches to NS commercial tree version of xpfe/bootstrap

Comment 12

[Bill Law]

I've renamed verifyRestrictedAccess to isAccessRestricted, as suggested.

I've also attached additional changes to files in the NS version of the
xpfe\bootstrap files (makefile.win and splash.rc).  I think I had emailed you
those, Sean (although I might have forgotten to include the makefile.win
changes).  Anyway, that's everything.

Comment 13

[Sean Su]

Comment on attachment 54285 [details] [diff] [review]
Patch for non-installer changes; mostly this is identical to the bug used to add this to the mozilla0.9.4 branch

r=ssu given law's latest comments.

Comment 14

[Bill Law]

fixed