1020184 - Update IONFLAGS error message to suggest --ion-parallel-compile=off

Status: RESOLVED INVALID

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp]]

(In reply to Amol Mundayoor from Bug 1012632 comment #27)
> In Comment #7, Nicolas mentioned that I could fix up an error message if I
> felt like it. I do feel like it, and found that the message is located at
> Ion.cpp:1914. Are there any preferences on what this should change to? I was
> simply thinking of appending "Re-run with flag --ion-parallel-compile=off"
> or something similar to the error string.

This sounds like a good plan. :)

Comment 1

[Amol Mundayoor]

Attachment: b1020184.patch

Here you go :)

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8436278 [details] [diff] [review]
b1020184.patch

Review of attachment 8436278 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Ion.cpp
@@ +1915,1 @@
>                                builderScript->filename(), builderScript->lineno());

style-nit: Avoid going above 100 characters per line.

   "%s:%d: Cannot log compilation due to background compilation.\n"
   "Re-run with the flag --ion-parallel-compile=off to disable the background compilation."

Comment 3

[Nicolas B. Pierron [:nbp]]

You might also want to take into consideration the work which is being done in Bug 1020364. ;)

Comment 4

[Himanshu Singh]

What's the current status of this bug?

Comment 5

[Yussif Barcelos]

Hi! I'm interested to fix one bug, but I'm new no bugzilla. I want to work in this bug and try to fix it until 30th october. Could someone mentor me?

Comment 6

[Nicolas B. Pierron [:nbp]]

Amol, can you fix the nit that I suggested in comment 2?

Himanshu, Yussif, If you are interested in fixing issues you can have a look at the documentation of SpiderMonkey, and how to build the JavaScript shell[1] then pick a bug on Bugs Ahoy[2].

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey
[2] http://www.joshmatthews.net/bugsahoy/?jseng=1

Comment 7

[Jinank Jain[:jj]]

Is this bug still exists?

Comment 8

[Nicolas B. Pierron [:nbp]]

(In reply to Jinank Jain from comment #7)
> Is this bug still exists?

This bug is now invalid, as Bug 1147403 part 3 added support for off-thread logging with IONFLAGS.