1020379 - [RTSP] Potential infinite loop and compile warnings in ARTPConnection.cpp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RTSP, defect)

Description

[Ethan Tseng [:ethan]]

We found a logical error from this changeset.
https://hg.mozilla.org/mozilla-central/rev/7770095ccedf

In ARTPConnection.cpp (line 248):
for (uint16_t port = start; port < 65536; port += 2) {
    ...
}

The for-loop local variable "port" was changed from "unsigned" to "uint16_t" carelessly. This change made the end condition being always true, which means this for-loop could be potentially infinite.
Although it's almost impossible to run into this logical error (e.g. all the UDP sockets are occupied), we should fix it to avoid the potential risk.

In the meanwhile, I found several compile warnings around this changeset. I will fix them as well in this bug.

Comment 1

[Ethan Tseng [:ethan]]

Attachment: Fix potential infinite loop

Fixed the issue mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1018288#c2.

Comment 2

[Ethan Tseng [:ethan]]

Attachment: Fix compile warnings around RTSP

This patch fixes the following warnings:
- ARTPConnection.cpp:284: warning: comparison between signed and unsigned integer expressions

- ARTSPConnection.h:91: warning: 'android::ARTSPConnection::mSocket' will be initialized after
  ARTSPConnection.h:88: warning: 'int32_t android::ARTSPConnection::mConnectionID'
  ARTSPConnection.cpp:54: warning: when initialized here RTSPSource.o

- RTSPConnectionHandler.h:44:1: warning: "LOGI" redefined

Comment 3

[Steve Workman [:sworkman] (INACTIVE)]

Thanks for taking care of this Ethan!

Comment 4

[Ethan Tseng [:ethan]]

(In reply to Steve Workman [:sworkman] from comment #3)
> Thanks for taking care of this Ethan!
You are welcome, Steve.
I am glad I can help!

Comment 5

[Ethan Tseng [:ethan]]

The result of Try server looks good.
https://tbpl.mozilla.org/?tree=Try&rev=ca63435dae22

Request to check in both patches.

Comment 6

[Ethan Tseng [:ethan]]

Attachment: Fix potential infinite loop

Refresh commit message "r=sworkman".

Comment 7

[Ethan Tseng [:ethan]]

Attachment: Fix compile warnings around RTSP

Refresh commit message "r=sworkman".

Comment 8

[Ethan Tseng [:ethan]]

Sorry I forgot to refresh commit messages before requesting to check in.
Please check in using the updated patches: attachment 8435994 [details] [diff] [review] and 8435996.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/cea5bf661931
https://hg.mozilla.org/integration/b2g-inbound/rev/722c6e0845eb

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cea5bf661931
https://hg.mozilla.org/mozilla-central/rev/722c6e0845eb