1020460 - Array.prototype.toSource should be generic

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bobby Holley (:bholley)]

Spoke with jorendorff about this on IRC. There's no reason for it to be non-generic, and having it be so makes this less safe for Xrays. Patch coming up.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Array.prototype.toSource should be generic. v1

Comment 2

[Bobby Holley (:bholley)]

Attachment: Array.prototype.toSource should be generic. v2

Needed to fix a test.

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 8434573 [details] [diff] [review]
Array.prototype.toSource should be generic. v2

Review of attachment 8434573 [details] [diff] [review]:
-----------------------------------------------------------------

Please throw in some trivial tests for applying this toSource method to non-array objects. (I don't care what the output is, as long as we don't crash.)

Comment 4

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eca7bdeb0c6e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/6502442e6133 along with bug 1021312 for apparently breaking a jsreftest: https://tbpl.mozilla.org/php/getParsedLog.php?id=41240513&tree=Mozilla-Inbound

Comment 6

[Bobby Holley (:bholley)]

Green try run (with some other stuff): https://tbpl.mozilla.org/?tree=Try&rev=12e2c896f82a

https://hg.mozilla.org/integration/mozilla-inbound/rev/e54cc67cf015

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e54cc67cf015

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/12161a842a8e