Closed Bug 1020615 Opened 10 years ago Closed 8 years ago

Ensure file names inside a packaged app are valid

Categories

(Marketplace Graveyard :: Validation, defect, P2)

2014-Q2
x86
macOS
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: andy+bugzilla, Unassigned)

Details

(Whiteboard: [marketplace-transition])

The app in bug 1013347 didn't sign properly because of issues handling utf-8 filenames in the signing code. But it doesn't point out that file names should be ascii or utf-8 as noted in:

http://www.pkware.com/documents/casestudies/APPNOTE.TXT

Bit 11: Language encoding flag (EFS).  If this bit is set,
                the filename and comment fields for this file
                MUST be encoded using UTF-8. (see APPENDIX D)

Given that, we should check that all the filenames are valid utf-8 before they get to signing, I'm guessing a valid encode/decode in python will do the trick. I'm not sure how important it is to do this, is it possible to generate a zip with invalidly encoded filenames?
Priority: -- → P2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Whiteboard: [marketplace-transition]
You need to log in before you can comment on or make changes to this bug.