1020744 - [Dialer][Flame] Enter more than 19 digits in dialer, back delete button moved couple pixels to the left

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: Merged.png

### STR
1. Enter 19 digits in dialer
2. Enter 1 more digit.
3. <ISSUE> back delete button moved couple pixels to the left.

### Reproduce rate 
100% on Flame and Buri

### Version Flame
Gaia      a38a6a5c6fabc97dd16d5360632b5ac5c7e06241
Gecko     https://hg.mozilla.org/mozilla-central/rev/951e3a671279
BuildID   20140604160202
Version   32.0a1

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: 19digits.png

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: 20digits.png

Comment 3

[Anthony Ricaud (:rik)]

Germán: Can you or Paco take a look at this?

Comment 4

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 5

[Anthony Ricaud (:rik)]

Eric: I can't reproduce this on today's master build. Can you retest?

Comment 6

[Eric Chang [:ericcc] [:echang]]

I found that is not happening exactly between 19-20, sometimes 21-22 or 22-23... 
https://www.youtube.com/watch?v=_8BqbYEx0Ls

### Flame aurora v2.0 (same on master v2.1)
Gaia      8d865839d932bfbd5e157f376f74d8cb12bfdd51
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/1d4046a8cb6c
BuildID   20140610000223
Version   32.0a2
ro.build.version.incremental=104
ro.build.date=Fri Jun  6 17:35:09 CST 2014
t2m.sw.version=B1TC400110H0

### Buri master v2.1 also has that issue
Gaia      e0c637f14265291ed81934058ec1cc019612127c
Gecko     https://hg.mozilla.org/mozilla-central/rev/13be61241671
BuildID   20140610160204
Version   33.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 8437477 [details] [review]
patch in github

Thanks!

You'll need to ask for approval to uplift this to 2.0.

Comment 8

[Paco Rampas [:paco]]

Comment on attachment 8437477 [details] [review]
patch in github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Wrong UX
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): no risk
[String changes made]:

Comment 9

[bhavana bajaj [:bajaj]]

Comment on attachment 8437477 [details] [review]
patch in github

low risk, polish change. Approving for uplift.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/5b4b4fc17a8e4a513a977f7062ea3e65d26ce268

Will uplift to v2.0 per the usual practices once this sticks on master.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/5b90b4d03bdaf29a5449d6bfc21d0d3c4e447457

Comment 12

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.1
Gecko-a3c4c53
Gaia-5f9f64a

Hamachi 
2.0
Gecko-3bfc06b
Gaia-5e14503

Comment 13

[Elie]

Attachment: VIDEO0062_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2