1021091 - servo builder git clean should clean ignored files too

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jack Moffitt [:jack]]

Can we make it run `git clean -fxd` instead of git clean -ffd`?

Comment 1

[[e-mail] (:bhearsum)]

Aki, there's currently no support for this in GittoolVCS. Any thoughts?

Comment 2

[Aki Sasaki (not active)]

(In reply to Ben Hearsum [:bhearsum] from comment #1)
> Aki, there's currently no support for this in GittoolVCS. Any thoughts?

There's vcs_config['clean'], which creates a --clean for gittool.py.
That seems to hook into http://hg.mozilla.org/build/tools/annotate/524bdee72020/lib/python/util/git.py#l133 , so we might want to ask the author about changing the options here.

Oh, that's you! :)  Any objections to changing that to -f -x -d instead of -f -f -d, Ben? :)  (or -f -f -x -d)

Comment 3

[[e-mail] (:bhearsum)]

Attachment: clean-harder.diff

(In reply to Aki Sasaki [:aki] from comment #2)
> (In reply to Ben Hearsum [:bhearsum] from comment #1)
> > Aki, there's currently no support for this in GittoolVCS. Any thoughts?
> 
> There's vcs_config['clean'], which creates a --clean for gittool.py.
> That seems to hook into
> http://hg.mozilla.org/build/tools/annotate/524bdee72020/lib/python/util/git.
> py#l133 , so we might want to ask the author about changing the options here.
> 
> Oh, that's you! :)  Any objections to changing that to -f -x -d instead of
> -f -f -d, Ben? :)  (or -f -f -x -d)

Oops :)

This patch will do it. We still want -f -f because that's for submodules, whic we also want to clean.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8435179 [details] [diff] [review]
clean-harder.diff

Should be fixed for any newly started jobs.