Closed
Bug 1021098
Opened 10 years ago
Closed 10 years ago
[vertical homescreen] Update unit tests for vertical homescreen
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zcampbell, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
The unit tests contain various hardcoded references to homescreen and some other obsolete methods of homescreen. These need to be updated
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jlorenzo
|
|
Assignee | |
Comment 1•10 years ago
|
||
I removed the part concerning switching from a page to another. Maybe we should check if the vertical homescreen is scrolling instead?
Attachment #8435327 -
Flags: feedback?(zcampbell)
Attachment #8435327 -
Flags: feedback?(viorela.ioia)
|
|
Assignee | |
Updated•10 years ago
|
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8435327 [details]
git commit
Looks good, although I think we should scroll to the bottom of the homescreen and assert that cleanup returns us to the top.
Attachment #8435327 -
Flags: feedback+
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8435327 [details]
git commit
The enhancement to scroll back to the top would be good too but that's broken/blocked in any case. I'll file a bug to follow up with this after it's fixed.
f+ too.
Attachment #8435327 -
Flags: feedback?(zcampbell)
Attachment #8435327 -
Flags: feedback?(viorela.ioia)
Attachment #8435327 -
Flags: feedback+
|
|
Reporter | |
Comment 4•10 years ago
|
||
Fixed in: https://github.com/mozilla-b2g/gaia/commit/ed0679ce06617961586a9c5697d8e79b5db38013
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•