Closed
Bug 1021276
Opened 10 years ago
Closed 10 years ago
The Comms Icons Need Colour Tweaks for Differentiation
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: padamczyk, Assigned: kgrandon)
References
Details
(Whiteboard: [systemsfe])
Attachments
(5 files, 2 obsolete files)
526.25 KB,
image/png
|
Details | |
125.98 KB,
application/zip
|
Details | |
46 bytes,
text/x-github-pull-request
|
arcturus
:
review+
praghunath
:
approval-gaia-v2.0+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
rik
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
julienw
:
review+
|
Details | Review |
Currently the first 3 icons are all the same colour and its hard to see the difference. Perhaps Phone needs to be more green. SMS needs to be more blue.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → pla
Blocks: vertical-homescreen
Assignee | ||
Comment 1•10 years ago
|
||
When will we have these? I'm not sure what kind of blocking criteria we will have for 2.0, so we would ideally have these assets today if we want to include them.
Updated•10 years ago
|
QA Whiteboard: [VH-FL-blocking-]
Hi Kevin, Here are the new Comms icons with greater separation of colour. I'm going to assign it to you now. Thanks again!
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8459132 -
Attachment is obsolete: true
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8459133 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8459134 [details] [review] Pull request - Update contacts app icons Francisco - could you take a look if you have time? Thanks!
Attachment #8459134 -
Flags: review?(francisco)
Assignee | ||
Comment 7•10 years ago
|
||
Etienne - Could you take a look if you have time? Thanks!
Attachment #8459135 -
Flags: review?(etienne)
Assignee | ||
Comment 8•10 years ago
|
||
Julien - could you take a look if you have time? Thanks!
Attachment #8459136 -
Flags: review?(felash)
Comment 9•10 years ago
|
||
Comment on attachment 8459136 [details] [review] Pull request - Update messages app icons r=me but you need to optimize the png files before merging. optipng (which I think is even not the best) could decrease the file size from 15% to 20% depending on the file, this is good to take IMO :)
Attachment #8459136 -
Flags: review?(felash) → review+
Updated•10 years ago
|
Attachment #8459135 -
Flags: review?(etienne) → review?(anthony)
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #9) > Comment on attachment 8459136 [details] [review] > Pull request - Update messages app icons > > r=me but you need to optimize the png files before merging. optipng (which I > think is even not the best) could decrease the file size from 15% to 20% > depending on the file, this is good to take IMO :) Good point, forgot about this. Will update these patches.
Comment 11•10 years ago
|
||
Comment on attachment 8459134 [details] [review] Pull request - Update contacts app icons Thanks Kevin!
Attachment #8459134 -
Flags: review?(francisco) → review+
Comment 12•10 years ago
|
||
Comment on attachment 8459135 [details] [review] Pull request - Update dialer app icons We even have tools/png_recompress.sh to do so.
Attachment #8459135 -
Flags: review?(anthony) → review+
Assignee | ||
Comment 13•10 years ago
|
||
Thanks all. Contacts: https://github.com/mozilla-b2g/gaia/commit/d30ad1662540da85e9013e5a7242761ffb09c8f1 Dialer: https://github.com/mozilla-b2g/gaia/commit/7bfb34f67eceae1878288f18b7ff9601013627e0 Messages: https://github.com/mozilla-b2g/gaia/commit/628490a9c482c1034f173011ffeb6170a0b9d11b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8459134 [details] [review] Pull request - Update contacts app icons Would like to request approval for 2.0 with the patches from these three bugs. All three patches are icons only and extremely low risk which give us some additional visual polish for the vertical homescreen.
Attachment #8459134 -
Flags: approval-gaia-v2.0?(bbajaj)
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.0 S6 (18july)
Updated•10 years ago
|
QA Whiteboard: [VH-FL-blocking-] → [VH-FL-blocking-][VH-FC-blocking-]
Updated•10 years ago
|
Attachment #8459134 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Comment 15•10 years ago
|
||
Needs rebasing for v2.0 uplift.
status-b2g-v2.0:
--- → affected
status-b2g-v2.1:
--- → fixed
Flags: needinfo?(kgrandon)
Target Milestone: 2.0 S6 (18july) → 2.1 S1 (1aug)
Assignee | ||
Comment 16•10 years ago
|
||
Squashed and uplifted: https://github.com/mozilla-b2g/gaia/commit/1bca63303bada6b53c0e50bc466c2a7d9d0a27a7
Flags: needinfo?(kgrandon)
You need to log in
before you can comment on or make changes to this bug.
Description
•