1021351 - [Homescreen] OTA update from horiz homescreen will not update to Vertical homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Tony Chung [:tchung]]

Attachment: screenshot of old homescreen after updating

Repro:
1) install 2.0 nightly and update to latest image with Vertical Homescreen enabled via OTA (6/4 build -> 6/5 build)

Gaia      d2cfef555dabab415085e548ed44c48a99be5c32
Gecko     https://hg.mozilla.org/mozilla-central/rev/51b428be6213
BuildID   20140605040202
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

2) restart phone after OTA update
3) verify the old homescreen is still present, not the new one


Expected:
- new vertical homescreen after OTA

Actual:
- old homescreen

Comment 1

[Jason Smith [:jsmith]]

Obviously we need to block on this.

Comment 2

[[e-mail]]

I think after OTA, user should change it manually in settings > homescreen, isn't it?

Comment 3

[Kevin Grandon :kgrandon]

I think we just need to bump the gecko settings version.

Comment 5

[Kevin Grandon :kgrandon]

Attachment: 0001-Bug-1021351-Update-settings-db-version-for-20.patch

I think this is mostly all we need to do for the setting? I think this is also probably necessary to upgrade edge gestures.

Comment 6

[Kevin Grandon :kgrandon]

Adding checkin-needed for: https://bug1021351.bugzilla.mozilla.org/attachment.cgi?id=8437079

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/479767da77af

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8437079 [details] [diff] [review]
0001-Bug-1021351-Update-settings-db-version-for-20.patch

This is needed for the vertical homescreen.
[User impact] if declined: We can not ship the vertical homescreen.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): We can not ship the vertical homescreen.
[String changes made]: None.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8437079 [details] [diff] [review]
0001-Bug-1021351-Update-settings-db-version-for-20.patch

Oops, maybe this is already blocking so it's not needed to ask for approval?

Comment 10

[Jason Smith [:jsmith]]

(In reply to Kevin Grandon :kgrandon from comment #9)
> Comment on attachment 8437079 [details] [diff] [review]
> 0001-Bug-1021351-Update-settings-db-version-for-20.patch
> 
> Oops, maybe this is already blocking so it's not needed to ask for approval?

Right - only non-blocking features need approval. This gets auto-approval.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/479767da77af

Comment 12

[:gerard-majax]

Taking the bug: I think I got the issue again this morning after updating a device, so I'll make sure we are okay on this.

Comment 13

[Kevin Grandon :kgrandon]

Doh.. Thanks for taking this Alex. Ping me on IRC if there's anything I can help with.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8d93866031c1

Comment 15

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #12)
> Taking the bug: I think I got the issue again this morning after updating a
> device, so I'll make sure we are okay on this.

So far, updated my Peak which was running a 2.0 from early may to current master, vertical homescreen is started by default. Looks good to me, good work!

Comment 16

[Johan Lorenzo [:jlorenzo]]

Verified by upgrading from mozilla-central-flame on 2014-04-17-04-02-06 to today's aurora. Vertical Homescreen is also started by default.