1021369 - [camera] self-timer icon is blank

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Tiffanie Shakespeare [:tif]]

STR: 

1. Launch Camera app
2. Go to Options menu and enable Self-Timer to any time

Expected
Indicator onscreen has self-timer image in it

Actual
There is an empty what square for the indicator

Comment 1

[Tiffanie Shakespeare [:tif]]

Attachment: blank self-timer icon

Comment 2

[Wilson Page [:wilsonpage]]

This regressed because of this commit: https://github.com/mozilla-b2g/gaia/commit/b303dbf72b9523f4a74ec055e18c943fb289ff82

I flagged this in review [1], but dmarcos must have missed it.

[1] https://github.com/dmarcos/gaia/pull/80/files#r13174028

Comment 3

[Jason Smith [:jsmith]]

Assuming that the timer still works here, I think this is worth fixing, but probably not a blocking issue.

Comment 4

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

We refer self-timer everywhere in the app and I changed the name of the icon to have consistency: icon-timer -> icon-self-timer

I forgot to also change the class name in the indicators view template. The attached PR fixes the issue. There are two commits:

1. It changes all the lines because this file still had windows end of lines.
2. It changes the css class name needed to fix the bug.

Comment 5

[Wilson Page [:wilsonpage]]

Comment on attachment 8436587 [details] [review]
Pull Request

Code looks good, assumed working. Just needs a squash :)

Comment 6

[Diego Marcos [:dmarcos]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/86da626923719d6550b4e0fccc67af27f96a02e4

Comment 7

[Tiffanie Shakespeare [:tif]]

Awesome! Thanks Diego!