1021375 - Tooltool doesn't work on (at least) windows c-c

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Hommey [:glandium]]

comm-central has tooltool setup, but no manifest. Since I wanted to try out mozmake on comm-central, I added a manifest, and the build failed with:

Cannot execute python, exiting
program finished with exit code 1
elapsedTime=0.208000
========= Finished 'sh c:/builds/moz2_slave/tb-try-c-cen-w32-0000000000000/tools/scripts/tooltool/tooltool_wrapper.sh ...' failed 

https://tbpl.mozilla.org/php/getParsedLog.php?id=41157755&tree=Thunderbird-Try

Comment 1

[Steve Fink [:sfink] [:s:]]

From a quick look, I'd say this is the problem (from tooltool_wrapper.sh):

    if [ ! -x "$TT_CMD" ]; then
        echo "Cannot execute $TT_CMD, exiting"
        exit 1

(TT_CMD is "python"). So this requires an absolute path, which seems kind of odd. Either that should be fixed (python *is* in $PATH in that log), an absolute path should be threaded through everything, or the invocation should be

  tooltool_wrapper.sh ... "$(which python)" ... 

instead of just using 'python'.

The 'python' comes from buildbot-configs/mozilla/thunderbird_config.py.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Allow TT_CMD to be found in $PATH

I'd probably go for something like this.

Comment 3

[Mike Hommey [:glandium]]

The thing is... the python that comes from buildbot-configs/mozilla/thunderbird_config.py is also python on m-c.

Comment 4

[Mike Hommey [:glandium]]

Ah! I see what the difference is! there is a python directory in the source directory on m-c. On c-c, it's in the mozilla/ subdirectory. So in one case, we're just lucky and not in the other.

Comment 5

[Steve Fink [:sfink] [:s:]]

Heh. It's a good(?) thing directories are executable. :-)

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8435496 [details] [diff] [review]
Allow TT_CMD to be found in $PATH

Well that was unexpected :)

Comment 7

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/build/tools/rev/bb2e379769db