102143 - with multiple tabs open, View Page Info always shows info for the first tab

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[jjkarppi]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4+) Gecko/20010927
BuildID:    2001092708

Having multiple tabs open, it's impossible to view page info except for the page
in the first tab.

Reproducible: Always
Steps to Reproduce:
1. Hit Ctrl-T to open a new tab
2. Go to some URL (different than what's in the first tab)
3. Select "View page info" 

Actual Results:  Shows info for the page in the first tab

Expected Results:  Should show page info for the tab that is currently selected

Comment 1

[Doron Rosenberg (IBM)]

-> tabbed browser

Comment 2

[Vidar B. Haarr (old account)]

confirmed on build 2001092803 and 2001093008 on Win2k SP2.

Comment 3

[[e-mail]]

Really confirming.

Comment 4

[Doron Rosenberg (IBM)]

Attachment: does it like we do it for frames

Comment 5

[Doron Rosenberg (IBM)]

basically call BrowserPageInfo(this.target.ownerDocument), which we do for frame
info. This also works with non tabbed.

Comment 6

[David Hyatt]

sr=hyatt

Comment 7

[Doron Rosenberg (IBM)]

anyone want to r=?

Comment 8

[Doron Rosenberg (IBM)]

Attachment: new patch

Comment 9

[Doron Rosenberg (IBM)]

only difference is patching navigatorOverlay's pageinfo function:

-    <command id="View:PageInfo"   oncommand="BrowserPageInfo();"/>
+    <command id="View:PageInfo"  
oncommand="BrowserPageInfo(getBrowser().contentDocument);"/>

thanks to fabian for catching that.

Comment 10

[David Hyatt]

sr=hyatt on new patch

Comment 11

[jag (Peter Annema)]

Comment on attachment 51881 [details] [diff] [review]
new patch

r=jag

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 103117 has been marked as a duplicate of this bug. ***

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 51881 [details] [diff] [review]
new patch

a=asa (on behalf of drivers) for checkin to 0.9.5

Comment 14

[timeless]

fixed

Comment 15

[Pratik]

I'm not sure if this is the same bug or should be filed as a separate bug but
clicking on the security lock at bottom right always shows security info for the
first Tab.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Different bug, please.

Comment 17

[Pratik]

Ok. Filed bug 103789

Comment 18

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2001.11.28.0x-comm bits on linux rh7.2, mac 10.1.1 and winnt.