Closed
Bug 1021950
Opened 10 years ago
Closed 10 years ago
Delete unwrapBkey from FxA user data after we fetch and calculate keys
Categories
(Firefox :: Firefox Accounts, defect)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
Firefox 33
People
(Reporter: ckarlof, Assigned: warner)
Details
Attachments
(1 file, 1 obsolete file)
1.90 KB,
patch
|
ckarlof
:
review+
|
Details | Diff | Splinter Review |
I believe this amounts to adding "delete data.unwrapBKey" here: http://hg.mozilla.org/mozilla-central/annotate/7146e89a7b83/services/fxaccounts/FxAccounts.jsm#l651 and adding some tests to make sure it gets deleted after a successful key fetch.
Assignee | ||
Comment 1•10 years ago
|
||
This should be everything.
Assignee | ||
Updated•10 years ago
|
Attachment #8437097 -
Flags: review?(ckarlof)
Assignee | ||
Comment 2•10 years ago
|
||
Ah, this format of patch should be slightly easier to mark checkin-needed.
Attachment #8437097 -
Attachment is obsolete: true
Attachment #8437097 -
Flags: review?(ckarlof)
Attachment #8437111 -
Flags: review?(ckarlof)
Reporter | ||
Updated•10 years ago
|
Attachment #8437111 -
Flags: review?(ckarlof) → review+
Assignee | ||
Comment 3•10 years ago
|
||
There are two unrelated tests which fail when I run the full suite, but those same tests fail when I run an unmodified git checkout (1f1507a8dac30b1bbf934a801d48a684cf375ae0). So I think this is ready for checkin.
Whiteboard: checkin-needed
Comment 4•10 years ago
|
||
Please provide a Try link when requesting checkin. If you need some recommendations on what to run, you can take a look at the below: https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices
Whiteboard: checkin-needed
Comment 5•10 years ago
|
||
http://tbpl.mozilla.org/?tree=Try&rev=2054a9e09b28
Assignee | ||
Comment 6•10 years ago
|
||
Thanks Nick! Ryan: is that sufficient? (sorry, I'm new at using checkin-needed).
Whiteboard: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/db50d648115a
Flags: in-testsuite+
Whiteboard: checkin-needed → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/db50d648115a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla33
Updated•6 years ago
|
Product: Core → Firefox
Updated•6 years ago
|
Target Milestone: mozilla33 → Firefox 33
You need to log in
before you can comment on or make changes to this bug.
Description
•