Closed
Bug 1022204
Opened 10 years ago
Closed 6 years ago
[Clock] Panels should start their transition outside the viewport, not at x=0.
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: RyanVM, Unassigned)
Details
https://tbpl.mozilla.org/php/getParsedLog.php?id=41282385&tree=Mozilla-Inbound b2g_ubuntu64_vm mozilla-inbound opt test gaia-ui-test on 2014-06-07 08:09:13 PDT for push 6932ea846a28 slave: tst-linux64-spot-1059 08:28:15 INFO - TEST-START test_clock_create_new_alarm.py 08:28:15 INFO - test_clock_create_new_alarm (test_clock_create_new_alarm.TestClockCreateNewAlarm) 08:28:45 INFO - Add an alarm and set label of the new alarm ... ERROR 08:28:45 INFO - ====================================================================== 08:28:45 INFO - ERROR: None 08:28:45 INFO - ---------------------------------------------------------------------- 08:28:45 INFO - Traceback (most recent call last): 08:28:45 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 170, in run 08:28:45 INFO - testMethod() 08:28:45 INFO - File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/clock/test_clock_create_new_alarm.py", line 62, in test_clock_create_new_alarm 08:28:45 INFO - edit_alarm.tap_done() 08:28:45 INFO - File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/apps/clock/regions/alarm.py", line 66, in tap_done 08:28:45 INFO - self.marionette.find_element(*self._done_locator).tap() 08:28:45 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 94, in tap 08:28:45 INFO - return self.marionette._send_message('singleTap', 'ok', id=self.id, x=x, y=y) 08:28:45 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/decorators.py", line 35, in _ 08:28:45 INFO - return func(*args, **kwargs) 08:28:45 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 633, in _send_message 08:28:45 INFO - self._handle_error(response) 08:28:45 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette.py", line 670, in _handle_error 08:28:45 INFO - raise ElementNotVisibleException(message=message, status=status, stacktrace=stacktrace) 08:28:45 ERROR - TEST-UNEXPECTED-FAIL | test_clock_create_new_alarm.py test_clock_create_new_alarm.TestClockCreateNewAlarm.test_clock_create_new_alarm | ElementNotVisibleException: ElementNotVisibleException: Element is not currently visible and may not be manipulated 08:28:45 INFO - ---------------------------------------------------------------------- 08:28:45 INFO - Ran 1 test in 30.435s 08:28:45 WARNING - FAILED (errors=1)
Comment 1•10 years ago
|
||
Hey guys, could anyone look at this? Also not sure which component these tests should go into. Zac - you have any preference if they are filed to the product component, or the Gaia UI tests component?
Flags: needinfo?(zcampbell)
Flags: needinfo?(m)
Comment 2•10 years ago
|
||
Zac, if you or someone would like help with this or need me to look at it, let me know. I'm happy to help if you'd like, but will wait to hear from you before attempting to dive in to the python tests.
Flags: needinfo?(m)
Comment 3•10 years ago
|
||
Mcav, I'll have a quick look and get back to you.
Flags: needinfo?(zcampbell)
Comment 4•10 years ago
|
||
Mcav, found the problem (actually seen the same problem before but it's raised its head again). When opening the edit alarm panel for an existing alarm, the panel is displayed at x=0, moved out of the viewport and then slides back in to x=0. Below is a console dump of the location of the "edit-alarm" panel. I think this is 50% clock app being coded that way and 50% Marionette incorrectly interpreting it as 'True' when it shouldn't be. Occasionally the wait that we have in the test resolves True when it catches the element before it has moved off the viewport (ie a false positive on the wait) and that causes this test failure. I'm not sure how to solve this right now, might do the dirty fix :/ edit-alarm: location edit-alarm: is_displayed {u'y': 50, u'x': 0} True {u'y': 50, u'x': 301.3833312988281} True {u'y': 50, u'x': 295.29998779296875} True {u'y': 50, u'x': 257.566650390625} True {u'y': 50, u'x': 257.566650390625} True {u'y': 50, u'x': 233.56666564941406} True --- snip ---
Comment 5•10 years ago
|
||
Pushed a quick n nasty fix. https://github.com/mozilla-b2g/gaia/commit/5650004abc18c96ac2877374f6a1b79d017ac664 Mcav, I'd like to be able to do a better fix than this ideally have Clock operate within the parameters of the test which are reasonable. Do you have any ideas?
Flags: needinfo?(m)
Comment 6•10 years ago
|
||
Ew, that's unfortunate. Yes, the panel should do something more reasonable. I'm going to usurp this bug for that, since you already landed a fix for the intermittent. Thanks for investigating!
Assignee: nobody → m
Flags: needinfo?(m)
Keywords: intermittent-failure
Summary: Intermittent test_clock_create_new_alarm.py test_clock_create_new_alarm.TestClockCreateNewAlarm.test_clock_create_new_alarm | ElementNotVisibleException: ElementNotVisibleException: Element is not currently visible and may not be manipulated → [Clock] Panels should start their transition outside the viewport, not at x=0.
Comment 7•10 years ago
|
||
Cleanup: unassigning myself from things that I'm not actively working on.
Assignee: m → nobody
Comment 8•6 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•