1022390 - [Vertical] Cancel download of apps

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P2)

Description

[James Lal [:lightsofapollo]]

The old homescreen would let you cancel ongoing downloads we should probably too.

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Stop download in progress

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Restart download

I think that the action is blue instead of red but when you will give me the feedback I address it, many thanks

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 4

[Jacqueline Savory [:jsavory] UX]

Cristain - For the Restart Download, I believe instead of the button saying "Resume" it should say "Download" if the download is starting from the beginning. If not, the title for that one should be changed. 

As you mentioned as well, the button should be blue not red for the restart download.

Comment 5

[Peter La]

Comment on attachment 8436900 [details]
Stop download in progress

Looks good!

Comment 6

[Peter La]

Comment on attachment 8436901 [details]
Restart download

This button should be blue and say 'Download', as Jacqueline mentioned in her comment.

Comment 7

[Cristian Rodriguez (:crdlc)]

ok, I gonna finish it today mates, at least I hope so XD

Comment 8

[Kevin Grandon :kgrandon]

Taking a look at this now. I'm having a hard time actually doing this on a device. It would be really good to write a marionette test for this stuff, but I understand it may be slightly tricky.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8436948 [details]
Github pull request

I left a few nits about event names on github, but overall this looks really good. Please either address the event name nits, or state your argument and you can land after doing either of those :) Thanks for the patch!

Comment 10

[Jacqueline Savory [:jsavory] UX]

Attachment: App Download June10.pdf

Attaching spec that includes the app installation states in a bit more detail. Let me know if there are any questions.

Comment 11

[Cristian Rodriguez (:crdlc)]

This bug is to cancel and resume downloads, please file a new bug regarding to "App Download Fails"

(In reply to jsavory from comment #10)
> Created attachment 8438099 [details]
> App Download June10.pdf
> 
> Attaching spec that includes the app installation states in a bit more
> detail. Let me know if there are any questions.

Comment 12

[Cristian Rodriguez (:crdlc)]

I agree with you so I addressed all comments

(In reply to Kevin Grandon :kgrandon from comment #9)
> Comment on attachment 8436948 [details]
> Github pull request
> 
> I left a few nits about event names on github, but overall this looks really
> good. Please either address the event name nits, or state your argument and
> you can land after doing either of those :) Thanks for the patch!

Comment 13

[Cristian Rodriguez (:crdlc)]

Peter, according to this spec we need a new image to indicate what an app failed downloading, could you assign it to somebody? Many thanks

(In reply to jsavory from comment #10)
> Created attachment 8438099 [details]
> App Download June10.pdf
> 
> Attaching spec that includes the app installation states in a bit more
> detail. Let me know if there are any questions.

Comment 14

[Cristian Rodriguez (:crdlc)]

comment 13 :)

Comment 15

[Peter La]

Hi Cristian,

Yes, I have 2 sets of graphics ready, but I'm waiting for approval of our first choice from the brand team.  I've asked them to reply by early/mid-day today.  If it takes any longer, we'll go with the second choice and I will attach the image assets to all the relevant bugs (3 of them I believe).

Stay tuned.

Comment 16

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/2ec8e0628192868d5bbe9fc964d45321ea6ea62a

Comment 17

[Johan Lorenzo [:jlorenzo]]

Cancel feature checked. Waiting for the new icon to mark this bug as verified.

Comment 18

[James Lal [:lightsofapollo]]

The visual work will happen here https://bugzilla.mozilla.org/show_bug.cgi?id=1023950

Comment 19

[Johan Lorenzo [:jlorenzo]]

It's verified then ;)

Comment 20

[Kevin Grandon :kgrandon]

Comment on attachment 8436948 [details]
Github pull request

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.

Comment 21

[Kevin Grandon :kgrandon]

Uplifted: https://github.com/mozilla-b2g/gaia/commit/7760cb0b064490fc84b9053f3d83ac4c637b6b58

Comment 22

[Peter La]

Attachment: AppInstallVisualAssets.zip