Closed
Bug 1022616
Opened 10 years ago
Closed 10 years ago
gen_template.pl generates busted chrome tests because its path to SimpleTest is wrong
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: Gijs, Assigned: Gijs)
Details
Attachments
(1 file)
1.19 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Existing tests use: chrome://mochikit/content/tests/SimpleTest/SimpleTest.js but the template ( http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/static/xul.template.txt ) generates: 9 <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"/> which 404s.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8436893 -
Flags: review?(jmaher)
Comment 2•10 years ago
|
||
Comment on attachment 8436893 [details] [diff] [review] mochitest chrome template uses broken path to SimpleTest.js, Review of attachment 8436893 [details] [diff] [review]: ----------------------------------------------------------------- thanks. on an unrelated note, do people still use these templates? I was under the impression it was more of a copy/paste from a similar test.
Attachment #8436893 -
Flags: review?(jmaher) → review+
Comment 3•10 years ago
|
||
I don't think I've ever used one of these templates, they're clearly not well-supported.
Comment 4•10 years ago
|
||
I think we'd be better-served just having a simple example test of each kind that developers could copy and paste. Having them be real example tests means they'd be actually run in production and would be up-to-date by necessity.
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4) > I think we'd be better-served just having a simple example test of each kind > that developers could copy and paste. Having them be real example tests > means they'd be actually run in production and would be up-to-date by > necessity. I would agree, but right now, this is still the recommended way (per docs) of creating new tests. I'd like to just land this, and file a followup bug to add simple sample tests, and a mach command to do what gen_template.pl does now based on those sample tests. I don't know if/when I will have time to do that, though. Does that sound OK?
Flags: needinfo?(ted)
Comment 6•10 years ago
|
||
That's fine. No point in blocking an already-written patch on a better solution.
Flags: needinfo?(ted)
Assignee | ||
Comment 7•10 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/c0a859335b41
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 8•10 years ago
|
||
Filed bug 1022683.
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c0a859335b41
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•