1022772 - SJCL should be unminified, versioned

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Adam Roach [:abr]]

Source code in the tree is supposed to be readable rather than minified. Also, for tracking purposes, we should be able to determine which version of code is in use.

Comment 1

[Adam Roach [:abr]]

Attachment: SJCL should be unminified, versioned

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8437038 [details] [diff] [review]
SJCL should be unminified, versioned

Review of attachment 8437038 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8

Comment 3

[Adam Roach [:abr]]

https://hg.mozilla.org/projects/elm/rev/b8172fae3ff7

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/b8172fae3ff7

Comment 5

[Gervase Markham [:gerv]]

Wonderful. But this is not the only minified library that's part of Loop, right? Is checking in the unminified source code of the others tracked by this bug, or are you planning to open a bug for each?

Gerv

Comment 6

[Adam Roach [:abr]]

(In reply to Gervase Markham [:gerv] from comment #5)
> Wonderful. But this is not the only minified library that's part of Loop,
> right? Is checking in the unminified source code of the others tracked by
> this bug, or are you planning to open a bug for each?

See https://bugzilla.mozilla.org/showdependencytree.cgi?id=1022871&hide_resolved=1

Comment 7

[u279076]

This doesn't appear to need QA before we release. Please needinfo me to request specific testing.