1022798 - testSystemPages loads about:healthreport, which accesses the network

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Nathan Froyd [:froydnj]]

We're working on prohibiting access to the network in bug 995417, and this test causes problems:

10:13:31     INFO -  31 INFO TEST-PASS | testSystemPages | The correct number of tabs are opened - 1 should equal 1
10:13:31     INFO -  32 INFO TEST-PASS | testSystemPages | Browser toolbar URL stayed the same - about:feedback should equal about:feedback
10:13:31     INFO -  33 INFO TEST-PASS | testSystemPages | waiting for urlbar text to gain focus - urlbar text gained focus
10:13:31     INFO -  34 INFO TEST-PASS | testSystemPages | URL typed properly - about:healthreport should equal about:healthreport
10:13:31     INFO -  35 INFO TEST-PASS | testSystemPages | Given message occurred for registered event: {"errorType":"","bgColor":"transparent","type":"DOMContentLoaded","tabID":0} - DOMContentLoaded should equal DOMContentLoaded
10:13:31     INFO -  EventExpecter: no longer listening for DOMContentLoaded
10:13:31     INFO -  INFO | automation.py | Application ran for: 0:01:55.302266
10:13:31     INFO -  INFO | zombiecheck | Reading PID log: /tmp/tmpR4vZQXpidlog
10:13:31     INFO -  Contents of /data/anr/traces.txt:
10:13:31     INFO -  mozcrash INFO | Downloading symbols from: https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-23ffae7aeca5/try-android/fennec-32.0a1.en-US.android-arm.crashreporter-symbols.zip
10:13:36  WARNING -  PROCESS-CRASH | testSystemPages | application crashed [@ nsSocketTransport::InitiateSocket()]
...

10:13:38     INFO -  06-09 10:13:19.421 E/GeckoConsole( 2768): AboutHealthReport: loading content from https://fhr.cdn.mozilla.net/en-US/mobile/?v=1
10:13:38     INFO -  06-09 10:13:19.437 I/Gecko   ( 2768): BAD CONNECT: connecting to fhr.cdn.mozilla.net

I can't tell whether there's a nice way to set up prefs to redirect this to some local server, or even whether there's a local server running for this suite like there is for mochitests.

Comment 1

[Geoff Brown [:gbrown]]

I suspect the url is determined by datareporting.healthreport.about.reportUrl. Test profiles override datareporting.healthreport.documentServerURI, but not datareporting.healthreport.about.reportUrl.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: set datareporting.healthreport.about.reportUrl in test profiles

With this change, testSystemPages continues to pass and other tests appear unaffected:

https://tbpl.mozilla.org/?tree=Try&rev=9181fde6f93b

If I run testSystemPages locally, I see that about:healthreport displays a 404 error briefly before the test continues (we no longer retrieve from the mozilla server).

I do not see any similar prefs set in reftests.py and am only aware of the testSystemPages issue, so am only updating prefs_general.js.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8437646 [details] [diff] [review]
set datareporting.healthreport.about.reportUrl in test profiles

Review of attachment 8437646 [details] [diff] [review]:
-----------------------------------------------------------------

this will affect all of mochitest, should we ensure we have this for reftest and talos as well?

Comment 4

[Geoff Brown [:gbrown]]

(In reply to Joel Maher (:jmaher) from comment #3)
> should we ensure we have this for reftest and talos as well?

It wouldn't hurt, but I'm not too concerned -- it seems unlikely that those tests would access about:healthreport.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b5121cef427

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0b5121cef427

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/06ffc9d82349
https://hg.mozilla.org/releases/mozilla-beta/rev/6f2a689ef536