Closed
Bug 1023010
Opened 10 years ago
Closed 10 years ago
Remove deprecated `depth` kwarg from `apps.versions.models`
Categories
(addons.mozilla.org Graveyard :: Code Quality, defect)
addons.mozilla.org Graveyard
Code Quality
Tracking
(Not tracked)
VERIFIED
FIXED
2014-08
People
(Reporter: cvan, Assigned: cvan)
References
Details
(Whiteboard: [qa+])
Attachments
(1 file)
234.46 KB,
image/png
|
Details |
Use `select_related(field_names)` instead of `select_related(depth=1)`. (Same as bug 1011676 but for AMO.)
Assignee | ||
Comment 1•10 years ago
|
||
https://github.com/mozilla/olympia/commit/7b78972 QA, please test the following: DevHub add-on activity pages, Version list of compatible apps, and Reviewer tool versions lists. Thanks!
Assignee: nobody → cvan
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [qa+]
Target Milestone: --- → 2014-08
Comment 2•10 years ago
|
||
The Add-on icons are missing in the Activity page http://screencast.com/t/83LnlAt0Rv . Is this a related issue? The version list are working properly in the Manage Version and Editor Tools pages.
Flags: needinfo?(cvan)
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Iulian Timis from comment #2) > The Add-on icons are missing in the Activity page > http://screencast.com/t/83LnlAt0Rv . Is this a related issue? The version > list are working properly in the Manage Version and Editor Tools pages. I don't think that's related. But let's see. Magopian, what do you think?
Flags: needinfo?(cvan)
Comment 4•10 years ago
|
||
It might be related to the staticfiles: Bug 1013865
Comment 5•10 years ago
|
||
I've had a look at the code, and didn't see how the recent changes could have changed the behaviour here, and we can see it's already broken in production. I does work on the feed/addon page, but not on the "all addons", and it's the same in dev/stage. At this point, I suggest to open a new bug, and not to make this a blocker for the current push. What do you all think?
Comment 6•10 years ago
|
||
I have filed Bug 1055449 for the issue described in Comment 2. Verified as fixed in https://addons.allizom.org/en-US/developers/ and https://addons.allizom.org/en-US/editors/ on FF31 (Win 7). Closing bug.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•