1023010 - Remove deprecated `depth` kwarg from `apps.versions.models`

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

Use `select_related(field_names)` instead of `select_related(depth=1)`.

(Same as bug 1011676 but for AMO.)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/olympia/commit/7b78972

QA, please test the following: DevHub add-on activity pages, Version list of compatible apps, and Reviewer tool versions lists. Thanks!

Comment 2

[Iulian Timis]

The Add-on icons are missing in the Activity page http://screencast.com/t/83LnlAt0Rv . Is this a related issue? The version list are working properly in the Manage Version and Editor Tools pages.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Iulian Timis from comment #2)
> The Add-on icons are missing in the Activity page
> http://screencast.com/t/83LnlAt0Rv . Is this a related issue? The version
> list are working properly in the Manage Version and Editor Tools pages.

I don't think that's related. But let's see. Magopian, what do you think?

Comment 4

[Mathieu Agopian [:magopian]]

It might be related to the staticfiles: Bug 1013865

Comment 5

[Yohan Boniface [:ybon]]

Attachment: /developers/feed from prod

I've had a look at the code, and didn't see how the recent changes could have changed the behaviour here, and we can see it's already broken in production. I does work on the feed/addon page, but not on the "all addons", and it's the same in dev/stage.

At this point, I suggest to open a new bug, and not to make this a blocker for the current push. 

What do you all think?

Comment 6

[Iulian Timis]

I have filed Bug 1055449 for the issue described in Comment 2.
Verified as fixed in https://addons.allizom.org/en-US/developers/ and https://addons.allizom.org/en-US/editors/ on FF31 (Win 7).
Closing bug.