1023133 - (2.1-visual-refresh)[Notifications and Alarms] - Add New Tones

Status: RESOLVED DUPLICATE of bug 1046399

(Firefox OS Graveyard :: Gaia::Ringtones, defect, P2)

Description

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

+++ This bug was initially created as a clone of Bug #1014009 +++

For the visual design refresh we have created a new set of ringtones to better reflect the visual style. These cover:
+ ringtones
+ alarms
+ message notifications

1. The WAV files are here: https://mozilla.box.com/s/6x15jupkdv98qbrrsgpy they need to be compressed. 
2. Current tones need to be replaced within the OS.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 2

[Patryk Adamczyk [:patryk] UX]

Attachment: Screenshot from the notification selection screen.

Pavel you need to name the notifications somewhere, just like the old set. Just use the file name. ie:
"notifier_bells.ogg" will be named: "bells"

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Patryk,
I made the changes ... and I think that this works now

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8437542 [details] [review]
patch for Gaia/master

Now my PR contains needed changes for Notifications and Alarms and looks ok on my hamachi

Comment 6

[Patryk Adamczyk [:patryk] UX]

Its still broken on the flame... Same error :(

Comment 7

[Patryk Adamczyk [:patryk] UX]

Comment on attachment 8437542 [details] [review]
patch for Gaia/master

Do you have a flame yet? Are you getting the same 
"make: *** [operatorvariant] Error 3" error I am getting?

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

not yet ... I expect it soon ... but I don't have such problems with my hamachi ... I will ping you back when I receive the flame and when I test the patch with it

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8437542 [details] [review]
patch for Gaia/master

Hey Patryk,

can you check it again with the steps who I send you on the email. I think I found the problem and I fixed it (I have a flame now and I have a chance to test this patch)

Comment 10

[Patryk Adamczyk [:patryk] UX]

Comment on attachment 8437542 [details] [review]
patch for Gaia/master

Looks good! Push them in.

Comment 11

[David Flanagan [:djf]]

Comment on attachment 8437542 [details] [review]
patch for Gaia/master

Jim, could you take this review please?

Comment 12

[David Flanagan [:djf]]

It looks like this bug is marked confidential becasue it was cloned from a confidential bug. Is there any reason it needs to be marked that way?

Comment 13

[Jim Porter (:squib)]

Comment on attachment 8437542 [details] [review]
patch for Gaia/master

This looks mostly good, but we're probably going to want a migration step when we upgrade. What if the user has picked a default notification sound that we've removed? It'll probably still play the old notification until they change it manually. We need to decide what to do here; maybe reset everyone's notification sound to the factory default?

Comment 14

[Jim Porter (:squib)]

Also, I can't review the clock changes, so you'll need to find someone from productivity to take a look at that.

Comment 15

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Patryk,
what do you think about Jim's comment?

Comment 16

[Stephany Wilkes]

This needs r+ and is too late for 2.1. If we think this is critical to get in for 2.0, let me know, but it really is too late.