Closed
Bug 1023365
Opened 10 years ago
Closed 10 years ago
Use touch events instead of mouse events for the software home button
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file)
|
2.14 KB,
patch
|
etienne
:
review+
|
Details | Diff | Splinter Review |
Bug 1005815 will disable mouse events coming along with touch events in the system app. This is a broken behavior on a touch device that is here more or less since the first day of touch events in Gaia. As a result some of our code rely on this broken behavior.
|
Assignee | |
Comment 1•10 years ago
|
||
Etienne I thought you will be a good reviewer for all this mouse/touch events madness. Let me know if I'm wrong.
Attachment #8437754 -
Flags: review?(etienne)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8437754 [details] [diff] [review] touchstart.software_home Review of attachment 8437754 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the software_button_manager_test.js updated accordingly (just need to rename the fake events there)
Attachment #8437754 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=b8547f80a8734143551f90db4780307b9f7e2bdb
Assignee: nobody → 21
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•10 years ago
|
||
Green. Landing. https://github.com/mozilla-b2g/gaia/commit/653065f3891f1d4c84d1bc0514c912974959d16f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•