1023392 - Intermittent localization_test.js | Vertical - Localization Localization updates icon names

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Jonathan Griffin (:jgriffin)]

07:38:02     INFO -  TEST-START | Vertical - Localization Localization updates icon names
07:38:21     INFO -  TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/verticalhome/test/marionette/localization_test.js | Vertical - Localization Localization updates icon names
07:38:21     INFO -  TEST-END | Vertical - Localization Localization updates icon names

https://tbpl.mozilla.org/php/getParsedLog.php?id=41447300&tree=B2g-Inbound&full=1

Comment 1

[Jason Smith [:jsmith]]

Kevin - This is the key blocker right now to why gaia integration tests are hidden on TBPL. Can you find someone to look into this or redirect to someone who can fix this?

Comment 2

[Kevin Grandon :kgrandon]

Oh sure, we actually had a patch for this that I believe got backed out of another bug. The fix for this isn't too bad.

Comment 3

[Kevin Grandon :kgrandon]

Attachment: Github pull request

James - I think you fixed this, but I'm not sure where. Should we land this?

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8438017 [details] [review]
Github pull request

Got a r+ from James over IRC.

Comment 5

[Kevin Grandon :kgrandon]

Looking very green on travis, and previously not as healthy: https://travis-ci.org/KevinGrandon/gaia/builds/27264072 

I think we can land this.

Comment 6

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/fca906183e6fae9463119a5fde3e397fcb9a6f5c

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8438017 [details] [review]
Github pull request

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.

Comment 8

[Kevin Grandon :kgrandon]

Uplifted: https://github.com/mozilla-b2g/gaia/commit/45f66fcf29ac1960d63862594c06bdd776bf45ab

Comment 9

[Legacy TBPL/Treeherder Robot]

mcjimenez
https://tbpl.mozilla.org/php/getParsedLog.php?id=44508188&tree=Gaia-Try
b2g_ubuntu64_vm gaia-try opt test gaia-integration on 2014-07-24 03:05:57
revision: 41264b8fd5b5
slave: tst-linux64-spot-529

TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/verticalhome/test/marionette/localization_test.js | Vertical - Localization Menu option localization
TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/system/test/marionette/homescreen_navigation_test.js | Homescreen navigation > Going to the homescreen and back to a warm app
AssertionError: we got 3 reflows instead of 2
make: *** [test-integration-test] Error 2
Return code: 2
Tests exited with return code 2: harness failures
# TBPL FAILURE #

Comment 10

[Lancy(Leave from Mozilla)]

Hi Jonathan,

Could you please provide the detailed reproduce steps or video for me to verify this bug?
Thank you very much!

Comment 11

[Kevin Grandon :kgrandon]

This looks like a test only issue. It's pretty clear from the bug title/description. No verification should be necessary.