1023860 - Canceling the UI flow should clean up pending content requests

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Canceling the Mobile ID UI flow leaves some pending content requests that makes the next run of the flow unstable.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Without this fix the mobile ID flow can't be used if the user cancels the flow once unless the user reboots the device, so I think it is worth taking the fix for 2.0.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20684

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Thanks Alive!

https://github.com/mozilla-b2g/gaia/commit/df6ab5855378dfd874fa69630a49cffcb4117111

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/0e788189b5490db66f11be2f655c2c2b2c215781

Comment 6

[Lancy(Leave from Mozilla)]

Fernando,

Could you please provide the detailed reproduce steps for me to verify this bug?
Thank you very much!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Hello Lancy,

if you are using an engineering build, you can trigger the Mobile ID flow from the "MobileIdentity" test from the "UITest privileged" app. You should be able to open the flow by clicking in any of the two buttons "Get assertion" or "Force selection". Once the flow is opened, you should be able to cancel it by clicking in the "X" button in the top left corner. Cancelling the flow should not affect the following launch and so you should be able to complete the flow and obtain the Mobile ID assertion.

If you are not using an engineering build, you can install the FxOS Loop client (https://github.com/mozilla-b2g/firefoxos-loop-client) that makes use of this API and follow the same process of triggering and cancelling the Mobile ID flow.

Comment 8

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/5

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0