1024109 - Fix Likes functionality in Profile

Status: RESOLVED FIXED

(Webmaker Graveyard :: Profile, defect)

Description

[Cassie McDaniel [:cassiemc]]

Attachment: profile-likes.jpg

The "liking" something functionality should work as expected on makes within the Likes tab on Profile.

Currently if I click on the heart on something I liked that shows up in my profile, I would expect it to "unlike" and be removed from my profile.

The behavior I see is that it actually just hides that tab's content.

We should consider how users might find that make again if they clicked the heart again in error, without meaning to unlike. Perhaps a dialogue box asking them to confirm.

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

@ Cassie: do you think we should punt all work in fixing "likes" until you've had a chance to re-examine their overall function on the site, as per your comment in last demo meeting?

* (Maybe a dumb idea -- just wondering!)

Comment 2

[Cassie McDaniel [:cassiemc]]

I think it makes sense to reassess later for sure, and let's file that bug, but this just seems broken... whereas the likes functionality works on other parts of the site. 

If this is hard to fix, maybe we should just remove this functionality from the profile for right now. Flagging Gavin for needinfo.

Comment 3

[Gavin Suntop [:gvn]]

We can make the hearts un-clickable at least. I always thought they were more of an informational component than a functional one, but we can certainly revisit that...

Comment 4

[Gavin Suntop [:gvn]]

Attachment: https://github.com/mozilla/webmaker-profile-2/pull/51