1024328 - Remove unnecessary #includes of nsFrameManager.h

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Daniel Holbert [:dholbert]]

In bug 1024084, I noticed that lots of things #include nsFrameManager.h without actually using it.

I filtered for files that #include nsFrameManager without actually using it by doing an MXR search for "FrameManager"...
http://mxr.mozilla.org/mozilla-central/search?string=FrameManager
...and looking for files with exactly one hit -- for just the #include.  (This easily screens out files that have e.g.
 presShell->FrameManager()->GetRootFrame()
which won't compile if it doesn't see the nsFrameManager definition.)

Upcoming patch removes the #include from the 10 .cpp files that I found w/ this technique. I verified that it builds locally w/ disable-unified-compilation, which I think means it's good.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v2

(er, now with the actual patch contents)

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 8438977 [details] [diff] [review]
fix v2

(thought I'd r+'ed this already)

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4224a22edac

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b4224a22edac