102453 - nsSpaceManager doesn't need an XPCOM interface

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsSpaceManager is entirely internal to layout -- it doesn't need an XPCOM
interface (nsISpaceManager).  If the interface were removed, we could even use
some inline functions for some of the simple things this does (particularly the
ones I'm going to add for bug 86947).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: cleaned-up patch

Comment 3

[Chris Waterson]

Comment on attachment 55106 [details] [diff] [review]
cleaned-up patch

sr=waterson

Comment 4

[Brendan Eich [:brendan]]

+  // Get the bouding rect of the trapezoid

typo alert.

Also, what does "semantic compare" mean?

/be

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I have to admit that I haven't even read all the code that I moved from one file
to the other. :-)

Comment 6

[jag (Peter Annema)]

Comment on attachment 55106 [details] [diff] [review]
cleaned-up patch

r=jag

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in 2001-10-25 22:05/06 PDT.