1024732 - PJS: Scheduler crash with large number of threads

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Shu-yu Guo [:shu]]

Using --thread-count=512 results in the following for me.

Assertion failure: state_ != TERMINATED, at /home/shu/moz/central/js/src/vm/ThreadPool.cpp:250

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Don't set PJS helper thread state to TERMINATED on error when starting the helper threads.

Comment 2

[Shu-yu Guo [:shu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a0c03f22654

Comment 3

[Mayank Bansal]

appears to have caused a 7.4% regression on AWFY on  Octane-deltablue on machine11

from AWFY: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e024afb9f1d9&tochange=1a0c03f22654

Comment 4

[Shu-yu Guo [:shu]]

(In reply to mayankleoboy1 from comment #3)
> appears to have caused a 7.4% regression on AWFY on  Octane-deltablue on
> machine11
> 
> from AWFY:
> http://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=e024afb9f1d9&tochange=1a0c03f22654

I find that very hard to believe...

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1a0c03f22654

Comment 6

[Mayank Bansal]

(In reply to Shu-yu Guo [:shu] from comment #4)
> (In reply to mayankleoboy1 from comment #3)
> > appears to have caused a 7.4% regression on AWFY on  Octane-deltablue on
> > machine11
> > 
> > from AWFY:
> > http://hg.mozilla.org/integration/mozilla-inbound/
> > pushloghtml?fromchange=e024afb9f1d9&tochange=1a0c03f22654
> 
> I find that very hard to believe...

Thats what AWFY says.
The deltablue benchmark on machine 11 shows a regression from 31743 to 29403