1025013 - add graph server definition for new tp5 scroll test

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in bug 1006551 we are adding tp5 scroll, we need graph server definitions.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: graphs_tp5scroll.patch

this should be short and simple!

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8439900 [details] [diff] [review]
graphs_tp5scroll.patch

># HG changeset patch
># Parent 2177454634275a61157bb30bba739d03a0027bf7
>Bug 1025013 - add graph server definition for new tp5 scroll test. r=rhelmer
>
>diff -r 217745463427 server/pyfomatic/collect.py
>--- a/server/pyfomatic/collect.py	Tue May 20 05:13:57 2014 -0400
>+++ b/server/pyfomatic/collect.py	Fri Jun 13 09:33:37 2014 -0400
>@@ -171,6 +171,13 @@
>     databaseCursor.connection.rollback()
>     raise DatabaseException("unable to update average 'test_runs' for id:%s : %s" % (metadata.test_run_id, str(x)))
> 
>+def _updateGeoMeanForTestRun(geomean, databaseCursor, inputStream, metadata):
>+  try:
>+    databaseCursor.execute("""update test_runs set geomean = %s where id = %s""", (geomean, metadata.test_run_id))
>+  except Exception, x:
>+    databaseCursor.connection.rollback()
>+    raise DatabaseException("unable to update geomean 'test_runs' for id:%s : %s" % (metadata.test_run_id, str(x)))
>+
> #-----------------------------------------------------------------------------------------------------------------
> def valuesReader(databaseCursor, databaseModule, inputStream, metadata):
>   for lineNumber, aLine in enumerate(inputStream):
>@@ -217,7 +224,20 @@
>   except Exception, x:
>     databaseCursor.connection.rollback()
>     raise DatabaseException("to determine average from 'test_run_values' for  %s - %s" % (metadata.test_run_id, str(x)))
>+
>   _updateAverageForTestRun(average, databaseCursor, inputStream, metadata)
>+
>+  # I am concerned that this might fail and we never 
>+  try:
>+    databaseCursor.execute("""select exp(sum(log(value))/count(value)) from test_run_values where test_run_id = %s""", (metadata.test_run_id))
>+    geomean = databaseCursor.fetchall()[0][0]
>+    if geomean is None:
>+      geomean = values[1]
>+  except Exception, x:
>+    databaseCursor.connection.rollback()
>+    raise DatabaseException("to determine geometric mean from 'test_run_values' for  %s - %s" % (metadata.test_run_id, str(x)))
>+
>+  _updateGeoMeanForTestRun(geomean, databaseCursor, inputStream, metadata)
>   databaseCursor.connection.commit()
>   return average
> 


Did you mean the "_updateGeoMeanForTestRun" for this patch?


>diff -r 217745463427 sql/data.sql
>--- a/sql/data.sql	Tue May 20 05:13:57 2014 -0400
>+++ b/sql/data.sql	Fri Jun 13 09:33:37 2014 -0400
>@@ -4570,4 +4570,5 @@
> insert into tests values (NULL,"sessionrestore_no_auto_restore","Session Restore no Auto Restore Test",1,1,NULL);
> 
> insert into tests values (NULL,"ts_paint_cold","TS Paint, Cold Load Time",1,1,NULL);
>+insert into tests values (NULL,"tp5o_scroll_paint","TP5 Scroll",1,1,15);
> 
>diff -r 217745463427 sql/schema.sql
>--- a/sql/schema.sql	Tue May 20 05:13:57 2014 -0400
>+++ b/sql/schema.sql	Fri Jun 13 09:33:37 2014 -0400
>@@ -78,6 +78,7 @@
>    run_number TINYINT UNSIGNED NOT NULL DEFAULT '0',
>    date_run INT UNSIGNED NOT NULL,
>    average FLOAT,
>+   geomean FLOAT,
> 
>    PRIMARY KEY (id),
>    KEY (test_id, build_id),

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: tp5 scroll sql for graph server (2.0)

it would help if I just give you my patch for the new test only, not a wip for data calculations.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

thanks rhelmer:
http://hg.mozilla.org/graphs/rev/652f4250cd49

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: tp5o_scroll without _paint (1.0)

boy do I like to do things twice!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks!
http://hg.mozilla.org/graphs/rev/5e2aa5cdd0ea