1026293 - Remove e.me as an available search engine and set new default in build

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Peter Dolanjski [:pdol]]

After meeting with e.me and going through the search plan in 2.0 and beyond, e.me has asked that they NOT be an available search engine for Rocketbar on homescreen, specifically after Enter press.

E.me, of course, would still be used as the user types but Enter press would take the user to one of the other search engines (based on what was configured in the build or what the user change the search engine to).

To be clear, the search engines available in the build (for now) should be: Google, Yahoo and Bing.  Google should be default, but of course this can be modified based on the market.

Comment 1

[Jason Smith [:jsmith]]

Based on dogfooding + exploratory testing, I'm not sure if we should consider having a default search engine. Most users appear to get confused when the enter operation produces different results than what is seen by autocomplete. Why not just return what is seen by autocomplete after hitting enter with the current search term?

Comment 2

[Peter Dolanjski [:pdol]]

Francis?

Comment 3

[Francis Djabri [:djabber]]

(In reply to Jason Smith [:jsmith] from comment #1)
> Based on dogfooding + exploratory testing, I'm not sure if we should
> consider having a default search engine. Most users appear to get confused
> when the enter operation produces different results than what is seen by
> autocomplete. Why not just return what is seen by autocomplete after hitting
> enter with the current search term?

Removing search terms may be confusing in the case of e.me when pressing enter, but opening a browser window and providing a list of search terms from one of the other default search providers would provide value and is what users are expecting based on the usability testing that we've done.

Comment 4

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/20632

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8441601 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20632

Seems to work fine, thanks!

Comment 6

[Jason Smith [:jsmith]]

Peter - Does this need to block 2.0? The bug reads off as something we need to do in the 2.0 timeframe.

Comment 7

[Peter Dolanjski [:pdol]]

(In reply to Jason Smith [:jsmith] from comment #6)
> Peter - Does this need to block 2.0? The bug reads off as something we need
> to do in the 2.0 timeframe.

Yes, it's probably the best course of action to block to avoid partner issues.

Comment 8

[Kevin Grandon :kgrandon]

Yuren - could you help us look into the maxBuffer issue we're seeing with this patch? Thanks!

Comment 9

[Kevin Grandon :kgrandon]

I think I found the problem, json syntax error. Let's see if this works and if not I'll open the ni? again.

Taking, but will likely just squash my changes into Ben's.

Comment 10

[Kevin Grandon :kgrandon]

Turns out there was an extra comma at the end of the JSON structure. I'm not sure why it gave the max buffer problem, I guess perhaps it was throwing a stack and overflowed the buffer?

Comment 11

[Kevin Grandon :kgrandon]

Got a green run and landed: https://github.com/mozilla-b2g/gaia/commit/bcb2115984ffdabc873f392678723f151cd880fd

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8441601 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/20632

This is needed for the vertical homescreen.

Comment 13

[Johan Lorenzo [:jlorenzo]]

Google is now the default one.

Comment 14

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/1b427aab595b6092cc6ccaeb5a9e65436bd93d8c