1026387 - [Dialer][Call log] 'missed' highlighted when tapping edit and back, then tapping 'all'

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: TextHighlightFlame.png

### STR
1. Have some missed entries call log.
2. Go to Missed tab.
3. Enter Edit mode, and leave by tapping the X. Do not delete anything.
https://www.youtube.com/watch?v=e2dAGVhhHns

### Actual result
1. 'Missed' has black highlight
2. See TextHighlightFlame.png TextHighlightBuri.png

### Expected result
1. Text label dont change.

### Version
Flame aurora v2.0
Gaia      0f254c92bc44d614ae56a855f18a895a7e4703ad
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/301e62e44f18
BuildID   20140616160201
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
t2m.sw.version=B1TC00011220

Buri aurora v2.0
Gaia      0f254c92bc44d614ae56a855f18a895a7e4703ad
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/301e62e44f18
BuildID   20140616160201
Version   32.0a2
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: TextHighlightBuri.png

Comment 2

[Eric Chang [:ericcc] [:echang]]

Hi, Etienne, Could you help to check this weird highlight, thank you.

Comment 3

[Etienne Segonzac (:etienne)]

Hey German, looks like a visual refresh follow up.
Maybe just adding a |-moz-user-select: none;| will be enough :)

Comment 4

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8443328 [details] [review]
patch in github

Thanks Paco!
I cannot reproduce that anymore after your patch :)

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 7bd538faeec769b976cf5e1380a86d4006097139

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Clearing German's ni as the issue is solved ;)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/0a485c1eb3fdbb385d89daf6a0b0a524c7227e19

Comment 9

[Kevin Grandon :kgrandon]

Reverted for causing bug 1029567, [B2G][Browser]Typing in a web address opens a blank white page. Perhaps the browser is not using these building blocks the proper way?

Master: https://github.com/mozilla-b2g/gaia/commit/2cede10a3f31d8734da193a4d16c3dbb8a751e6a
2.0: https://github.com/mozilla-b2g/gaia/commit/9685d84f016e370f67a80be6b32045f5cabf7a87

Paco - could we by chance get a call-log specific patch, or another patch that does not break browser? Thanks!

Comment 10

[Jason Smith [:jsmith]]

Flagging NO_UPLIFT for being the root cause of a smoketest, so this has to get approval to land.

Comment 11

[Kevin Grandon :kgrandon]

It also looked like this one caused some problems with the email app as noted in bug 1029567. Just making a note that we should check that before landing again.

Comment 13

[James Burke [:jrburke]]

This change affected email so badly because .bb-tablist has a height: 100% on it. However, the ul for that list of buttons on the bottom of the message list and message reader is just one part of the UI, just used for the bottom row of buttons, and there are other sibling elements above it for the message contents.

By changing the height: auto for .bb-tablist in the shared tabs.css, that seemed to work better -- the ul did not take up the full screen, just the size of the bottom buttons. When the background for .bb-tablist was changed to white and with a height of 100%, that meant it covered up the email contents, since the ul was the higher z order element.

It is unclear to me why .bb-tablist needs to be height 100%, but if this white background is needed, it may be worth revisiting why the height needs to be 100%.

Comment 14

[Eric Chang [:ericcc] [:echang]]

Attachment: EmailLoadingMessagesWithBlackSquare.png

Yes, I saw this in email, but unable to figure out the exact STR. And settings as well, saw this in bluetooth menu.
(In reply to Kevin Grandon :kgrandon from comment #11)
> It also looked like this one caused some problems with the email app as
> noted in bug 1029567. Just making a note that we should check that before
> landing again.

Comment 15

[Eric Chang [:ericcc] [:echang]]

Attachment: SettingsTextHighlighted-2.png

Bluetooth in Settings  affected as well, no exact STR.

Comment 16

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 17

[Paco Rampas [:paco]]

We have changed the background for affecting only on filters. Now, the problems on browser and email should be disappear. Could you check?

Comment 18

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8446372 [details] [review]
patch in github

Regressions in the previous bug were caused in apps were .bb-tablist was not properly used.
Unfortunately Tabs BB is not one of the best components we have, we will probably have a better solution when using web components.
New Paco's patch applies the background only to filters (.bb-tablist[data-type="filter"]) So now white screens are not appearing anymore.

Sorry for the inconveniences in the regression as I did not checked email app (just call log, calendar, clock and music) and was not expecting that behavior in browser app.

Comment 19

[Maria Angeles Oteo (:oteo)]

Jason, Eric, can Arnau land the patch in master so you can test there is no regressions in that branch before doing the uplifting to 2.0 or do you want to test the patch before?

Comment 20

[Jason Smith [:jsmith]]

(In reply to Maria Angeles Oteo (:oteo) from comment #19)
> Jason, Eric, can Arnau land the patch in master so you can test there is no
> regressions in that branch before doing the uplifting to 2.0 or do you want
> to test the patch before?

That works for me.

Comment 21

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: b61f480d9d97da617b5e0d7319b51623ed3ecaf3

Comment 22

[Maria Angeles Oteo (:oteo)]

(In reply to Jason Smith [:jsmith] from comment #20)
> 
> That works for me.

Thanks Jason, setting "verifyme" so QA can confirm that the bug is resolved and no more regressions raise before uplifting to 2.0

Comment 23

[Maria Angeles Oteo (:oteo)]

Harvey, can you confirm all is ok, so we can remove the [NO_UPLIFT] whiteboard and allow the uplifting to 2.0, thanks a lot!

Comment 24

[Jason Smith [:jsmith]]

Switching needinfo to the lead to have someone from the smoke team look at this.

Comment 25

[Harvey]

Already have the info on the master build encase this is useful.

I am unable to reproduce this issue on the latest Flame Master build.

Environmental Variables:
Device: Flame Master
Build ID: 20140629193729
Gaia: de14e61098b742251b34f856e48649db8bed552c
Gecko: b6408c32a170
Version: 33.0a1 (Master)
Firmware Version: v122

Comment 26

[Peter Bylenga [:PBylenga]]

I can verify this as fixed, for the white page regression I checked Browser, Call logs, Email, Calendar, Music, Clock, Bluetooth menu, Developer Options, and Contacts.

Environmental Variables:
Device: Flame Master
Build ID: 20140630040201
Gaia: de14e61098b742251b34f856e48649db8bed552c
Gecko: b6408c32a170
Version: 33.0a1 (Master)
Firmware Version: v122

Comment 27

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/33fcc20aa3b9be4964a67d320445e7da2347d19f

Comment 28

[Eric Chang [:ericcc] [:echang]]

Verified okay with these 2 builds.
Flame - aurora - v2.0
Gaia e935f4ff190b76c70d9b2af8856c542a6e4a7546
Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/3f9d7a3a0b7b
BuildID 20140707160206
Version 32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Flame - master - v2.1
Gaia 1dc9e53393ae4680a174dffa44a958ec564ebbe8
Gecko https://hg.mozilla.org/mozilla-central/rev/dfef245594b6
BuildID 20140707160202
Version 33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220