Closed Bug 1026636 Opened 10 years ago Closed 10 years ago

Uplift tbpl fixes in firefox33 branch to firefox32 branch of the addon-sdk repo

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(firefox32 fixed, firefox33 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla32
Tracking Flags:
Tracking Status
firefox32 --- fixed
firefox33 --- fixed

People

(Reporter: evold, Assigned: evold)

References

(
URL
)

Details

Attachments

(1 file)

1026636.patch
25.89 KB, patch
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → evold
Depends on: 1024837
What's the process for uplifting this diff?
Flags: needinfo?(ryanvm)
Attached patch 1026636.patch — — Splinter Review 
I'm not sure who to ask for a review to uplift this.
Attachment #8441769 - Flags: review?(dtownsend+bugmail)
Since this affects non-test code, you'll need to request Aurora approval on the patch and fill out the form it gives you.
Flags: needinfo?(ryanvm)
And once approved, you do the normal SDK uplift process, but you use the SDK's firefox32 branch, and you push it to Firefox's mozilla-aurora branch.
(In reply to Wes Kocher (:KWierso) from comment #6)
> And once approved, you do the normal SDK uplift process, but you use the
> SDK's firefox32 branch, and you push it to Firefox's mozilla-aurora branch.

I did this and tried the patch over at https://tbpl.mozilla.org/?tree=Try&rev=074590aff768  I'm pretty sure those failures are unrelated too.
Comment on attachment 8441769 [details] [diff] [review]
1026636.patch

Uplifts don't need review, they do need approvals though, follow the process in comment 5.
Attachment #8441769 - Flags: review?(dtownsend+bugmail)
Comment on attachment 8441769 [details] [diff] [review]
1026636.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1020458 and bug 1020463 
User impact if declined: None
Testing completed (on m-c, etc.): fx-tree and m-c
Risk to taking this patch (and alternatives if risky): None, this is all test code
String or IDL/UUID changes made by this patch: Not sure what this is.
Attachment #8441769 - Flags: approval-mozilla-aurora?
Priority: -- → P1
Comment on attachment 8441769 [details] [diff] [review]
1026636.patch

We like tests. Taking it for 32.
Attachment #8441769 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/ebff751502d3

*fingers crossed*
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox32: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: