1026698 - (2.1-visual-refresh)[Ringtones] Add & Set New System Notifications

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[Patryk Adamczyk [:patryk] UX]

Can you please do the following:
1. Add "Firefox_Notify" to the notification selection list in Settings
2. Make "Firefox_Notify" the default notification for the entire device. ie. When notifications come in. When the user takes a screenshot.
3. Remove the current sound for the notification from Gaia (we don't need it)
4. Make "Firefox_Sent" the default sending sound for Email
5. Remove the current sound for sending
6. Make "Firefox_MSG_Sent" the default sending sound for Messages, if you can't then use "Firefox_Sent" instead

The files can be found here:
https://mozilla.box.com/s/abqt9v8hwuh8uixzo6sq

Comment 1

[Jim Porter (:squib)]

I expect migration is going to be the hard part here. We might be able to punt and say "when you update to Firefox OS 2.0, we'll just reset your ringtone to the factory default". It'd be nice if we could keep user-created ringtones set, but that's hard to detect from a 1.4 install.

If we do something like this, make sure to keep me in the loop, since it'll mean we can simplify some mozSettings-compatibility stuff that I added.

Comment 2

[Patryk Adamczyk [:patryk] UX]

We can release the old tones on github. But v.2 is a big release, its like updating from Windows Vista to Windows 7, wallpapers and sound notifications changed.

Comment 3

[Patryk Adamczyk [:patryk] UX]

Attachment: fx_notifiers.zip

Pavel, can you please read Comment 1 and try to get these in?

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 5

[Patryk Adamczyk [:patryk] UX]

Comment on attachment 8470164 [details] [review]
patch for Gaia/master

Great, it works.

Comment 6

[Jim Porter (:squib)]

Comment on attachment 8470164 [details] [review]
patch for Gaia/master

This looks good, except for one comment I have on Github, so r=me with that addressed.

Note that I haven't tried this patch out, and I have no idea if these are the right sounds to use. I assume Patryk's f+ means the right sounds are being used in the right spots. :)

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :) 

can I merge it now?

Comment 8

[Jim Porter (:squib)]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #7)
> Thanks :) 
> 
> can I merge it now?

Well, you'll need to add notifier_firefox_notify.opus to replace the .ogg version first. And do please remember to create the Opus file from a lossless version of notifier_firefox_notify. :) Patryk might be able to help with that if you don't have the lossless version.

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Patryk,
can you help?

Comment 10

[Patryk Adamczyk [:patryk] UX]

Hey Pavel, its already attached to the bug: FX Notifiers.zip.
As an FYI all future sounds will be OPUS.

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

oh ... yeah ... i renamed it on notifier_firefox.opus sorry

Hey Jim,
the file is there and the name is notifier_firefox.opus I fixed the test with this file, thanks :)

Comment 12

[Jim Porter (:squib)]

Ok, I added a couple of new notes to GitHub. If you could fix those, that would be great. Thanks!

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Jim,
can you check it one more time? 

Thanks in advance :)

Comment 14

[Jim Porter (:squib)]

Everything looks good now. Land whenever you're ready! (Note that I haven't tested the individual apps, but I *have* tested that the audio files are correct.)

Comment 15

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

I made some tests and everything looks good :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/70f3935608c9e21461db8f60c50ae1be78a4460c

Comment 16

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

this pull break gaia build unit test

Comment 17

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I will send a pull request to fix it.

Comment 18

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged.

https://github.com/mozilla-b2g/gaia/commit/193e46e885a53adefd0346725b3fc9b13e2dacae