1026828 - Restore MOZ_STORAGE_MEMORY for system jemalloc

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Jan Beich]

Attachment: fix

Bug 938730 disabled MOZ_STORAGE_MEMORY for system sqlite. But it didn't take into account MOZ_MEMORY is also defined when system jemalloc is (auto)detected. With system jemalloc there's only one allocator and it's the default one.

For one, FreeBSD 10.0-RELEASE has jemalloc-3.4.0 as the default allocator and which can replace memory/jemalloc.

Comment 1

[Jan Beich]

Comment on attachment 8441779 [details] [diff] [review]
fix

https://tbpl.mozilla.org/?tree=Try&rev=db0708dbb4a1

Comment 2

[Carsten Book [:Tomcat]]

The Try run has 2 red builds  with

LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt 

is this related to the patch here ?

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d06ae272ade3

Comment 4

[Jan Beich]

(In reply to Carsten Book [:Tomcat] from comment #2)
> The Try run has 2 red builds  with
> 
> LINK : fatal error LNK1123: failure during conversion to COFF: file invalid
> or corrupt 
> 
> is this related to the patch here ?

Sorry, I've wanted to retrigger the jobs but level 1 access doesn't seem to be enough. Those errors were of course unrelated. The patch risk is low: either broken build (typos, #error in mozmemory.h) or regressing bug 938730 (operator precedence).

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d06ae272ade3