1027113 - talos session restore tests access hundreds of external resources

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

oh, over 33000 attempts, can this really be the case.  Today, the honorable :edmorley pushed a patch that printed a warning out for all external network access:
https://tbpl.mozilla.org/?tree=Try&rev=c088826545b9&jobname=talos

an example of a log with the errors is here:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41959719&tree=Try&full=1

You can click on any of the 'o' tests and then view the brief or full log and your mouth will make a 'O'.  

What I see is access to:
abs.twimg.com
drive.google.com
ssl.gstatic.com

these are all part of the sessionrestore file which shouldn't be making network connections.  We either need to fix session restore to not connect automatically, or adjust the test to use local resources.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Yoric, can you comment on what the appropriate path here would be?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Oh, I thought that this was benign. I'll prepare a fix.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Getting rid of these calls to the network

This patch replaces basically every "http://" and "https://" string in sessionstore.js with "http://localhost:8080/?", which should get rid of network accesses.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8442298 [details] [diff] [review]
Getting rid of these calls to the network

Review of attachment 8442298 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

landed:
https://hg.mozilla.org/build/talos/rev/02f95c7e7c06

once I get some preferences in talos and a few other fixes to network access done we will deploy!

Comment 6

[Ed Morley [:emorley]]

Thank you everyone for filing, fixing and reviewing so quickly!
I thought I was going to have to go through and find/file/hassle deps of bug 1026970 myself hehe :-)

Comment 7

[Ed Morley [:emorley]]

I'm presuming this caused:

Improvement: Mozilla-Inbound-Non-PGO - Session Restore no Auto Restore Test - Ubuntu HW 12.04 - 55.1% decrease
--------------------------------------------------------------------------------------------------------------
     Previous: avg 1523.992 stddev 14.000 of 12 runs up to revision 7b174d47f3cc
     New     : avg 683.583 stddev 9.703 of 12 runs since revision d4156937826a
     Change  : -840.408 (55.1% / z=60.029)
     Graph   : http://mzl.la/1pyPlYl

Changeset range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7b174d47f3cc&tochange=d4156937826a

Changesets:
   * http://hg.mozilla.org/integration/mozilla-inbound/rev/d4156937826a
     : Joel Maher <[e-mail]> - Bug 1028999 - Update talos to get recent changes. r=avih
     : http://bugzilla.mozilla.org/show_bug.cgi?id=1028999

Bugs:
   * http://bugzilla.mozilla.org/show_bug.cgi?id=1028999 - Update talos to get recent changes 

...and that this is not a problem? :-)

Comment 8

[Ed Morley [:emorley]]

Sorry ignore comment 7, that was actually bug 1027616.