1027396 - Stk Timer Expiration Envelope Command requires timer value

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Spencer]

Timer Expiration Envelope Command requires a timer value. Currently only a timerId is included in the Timer Expiration message.

Timer value is included in the Timer Expiration Envelope Command as specified in 3GPP TS 11.14 section 10.2 "Structure of ENVELOPE (TIMER EXPIRATION)": 

"Timer value: difference between the time when this command is issued and the time when the timer was initially started. This should be as close as possible to the value of the timer given in the initial TIMER MANAGEMENT command."

https://github.com/mozilla-b2g/gaia/blob/9141d16e1881eda5192b7b1dc6a7174d2b0a8613/apps/system/js/icc_worker.js#L445

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

You mean add the TimerValue into the sendStkTimerExpiration call?
The same one used bellow here: https://github.com/mozilla-b2g/gaia/blob/9141d16e1881eda5192b7b1dc6a7174d2b0a8613/apps/system/js/icc_worker.js#L454 ?

Comment 2

[Spencer]

Yes add that timerValue into the sendStkTimerExpiration call.

Comment 3

[howie [:howie]]

Hi Spencer, could you provide the user impact here? Thanks.

Comment 4

[Spencer]

Howie: This bug fix is necessary to meet specifications (3GPP TS 11.14). The SIM Timer Expiration Envelope Command has been implemented but remains buggy. - Spencer

Comment 5

[howie [:howie]]

Hi Fernando, could you help with this? thank you

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Inform the real used time to the SIM Card

@Spencer, The proposed patch sends the real needed time in seconds. Is it needed in ms?

Comment 7

[Carol Yang [:cyang]]

Comment on attachment 8472896 [details] [review]
Inform the real used time to the SIM Card

Hi Fernanado, yes, sending the time in seconds is perfect!

Just verified this patch and it's working as expected.

Comment 8

[Evelyn Hung]

Comment on attachment 8472896 [details] [review]
Inform the real used time to the SIM Card

Looks good to me.

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/5fae8a02bc31d28a4a76371bd9b0c8ef98a4b4f4