1027440 - Test plugins are not built in gtk3 builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

As a consequence, several tests are broken.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Build test plugins when building with --enable-default-toolkit=cairo-gtk3

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8442621 [details] [diff] [review]
Build test plugins when building with --enable-default-toolkit=cairo-gtk3

>+elif toolkit in ('gtk2', 'gtk3'):
>     UNIFIED_SOURCES += [
>         relative_path + '/nptest_gtk2.cpp',

I guess we don't need a specific nptest_gtk3.cpp?

Comment 3

[Mike Hommey [:glandium]]

(In reply to Michael Shal [:mshal] (no reviews until 6/30) from comment #2)
> I guess we don't need a specific nptest_gtk3.cpp?

No, and in fact, the gtk3 build builds gtk2 plugins.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e2d182304f6

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2e2d182304f6